Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/ocp_timeout #218

Merged
merged 1 commit into from
Jun 29, 2024
Merged

fix/ocp_timeout #218

merged 1 commit into from
Jun 29, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Jun 29, 2024

inform ovos-core this skill ignored a media type query, otherwise the OCPQuery will block for 15 seconds waiting for an answer that never comes

companion to OpenVoiceOS/ovos-core#517

inform ovos-core this skill ignored a media type query, otherwise the OCPQuery will block for 15 seconds waiting for an answer that never comes

companion to OpenVoiceOS/ovos-core#517
@JarbasAl JarbasAl added the bug Something isn't working label Jun 29, 2024
@JarbasAl JarbasAl requested review from goldyfruit, mikejgray and a team June 29, 2024 16:48
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@128464c). Learn more about missing BASE report.

Files Patch % Lines
ovos_workshop/skills/common_play.py 0.00% 22 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #218   +/-   ##
======================================
  Coverage       ?   53.28%           
======================================
  Files          ?       37           
  Lines          ?     4256           
  Branches       ?        0           
======================================
  Hits           ?     2268           
  Misses         ?     1988           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goldyfruit
Copy link
Member

Oh that is wayyyyyy faster!

Jun 29 13:41:23 mark2 ovos-core[67361]: 2024-06-29 13:41:23.632 - skills - ovos_core.transformers:transform:64 - DEBUG - ovos-utterance-cancel: {}
Jun 29 13:41:23 mark2 ovos-core[67361]: 2024-06-29 13:41:23.635 - skills - ovos_core.transformers:transform:64 - DEBUG - ovos-utterance-corrections: {'client_name': 'ovos_dinkum_listener', 'source': 'audio', 'destination': ['skills'], 'transcriptions': [['play a song radio', 0.72717869]], 'lang': 'en-us'}
Jun 29 13:41:23 mark2 ovos-core[67361]: 2024-06-29 13:41:23.642 - skills - ovos_core.transformers:transform:64 - DEBUG - ovos-utterance-normalizer: {'client_name': 'ovos_dinkum_listener', 'source': 'audio', 'destination': ['skills'], 'transcriptions': [['play a song radio', 0.72717869]], 'lang': 'en-us'}
Jun 29 13:41:23 mark2 ovos-core[67361]: 2024-06-29 13:41:23.645 - skills - ovos_core.intent_services:_handle_transformers:173 - DEBUG - utterances transformed: ['play a song radio'] -> ['play a song radio', 'play song radio']
Jun 29 13:41:23 mark2 ovos-core[67361]: 2024-06-29 13:41:23.656 - skills - ovos_core.intent_services:get_pipeline:251 - DEBUG - Session pipeline: ['stop_high', 'converse', 'ocp_high', 'padatious_high', 'adapt_high', 'ocp_medium', 'fallback_high', 'stop_medium', 'adapt_medium', 'padatious_medium', 'adapt_low', 'common_qa', 'fallback_medium', 'fallback_low']
Jun 29 13:41:23 mark2 ovos-core[67361]: 2024-06-29 13:41:23.658 - skills - ovos_core.intent_services:handle_utterance:392 - DEBUG - no match from <bound method StopService.match_stop_high of <ovos_core.intent_services.stop_service.StopService object at 0x7f78507990>>
Jun 29 13:41:23 mark2 ovos-core[67361]: 2024-06-29 13:41:23.682 - skills - ovos_core.intent_services:handle_utterance:392 - DEBUG - no match from <bound method ConverseService.converse_with_skills of <ovos_core.intent_services.converse_service.ConverseService object at 0x7f786baf90>>
Jun 29 13:41:24 mark2 ovos-core[67361]: 2024-06-29 13:41:24.149 - skills - padacioso:calc_intent:255 - DEBUG - {'entities': {'query': 'a song radio'}, 'conf': 0.96, 'name': 'play'}
Jun 29 13:41:24 mark2 ovos-core[67361]: 2024-06-29 13:41:24.151 - skills - ovos_core.intent_services.ocp_service:match_high:355 - INFO - OCP exact match: {'entities': {'query': 'a song radio'}, 'conf': 0.96, 'name': 'play'}
Jun 29 13:41:24 mark2 ovos-core[67361]: 2024-06-29 13:41:24.265 - skills - ovos_core.intent_services.ocp_service:classify_media:727 - INFO - OVOSCommonPlay MediaType prediction: radio confidence: 0.496
Jun 29 13:41:24 mark2 ovos-core[67361]: 2024-06-29 13:41:24.266 - skills - ovos_core.intent_services.ocp_service:classify_media:728 - DEBUG -      utterance: a song radio
Jun 29 13:41:24 mark2 ovos-core[67361]: 2024-06-29 13:41:24.268 - skills - ovos_core.intent_services:handle_utterance:380 - INFO - ocp_high match: IntentMatch(intent_service='OCP_intents', intent_type='ocp:play', intent_data={'media_type': <MediaType.RADIO: 7>, 'query': 'a song radio', 'entities': {}, 'skills': [], 'conf': 0.96, 'media_conf': 0.496, 'lang': 'en-us'}, skill_id='ovos.common_play', utterance='a song radio')
Jun 29 13:41:24 mark2 ovos-core[67361]: 2024-06-29 13:41:24.272 - skills - ovos_core.intent_services:handle_utterance:398 - DEBUG - intent matching took: 0.6156611442565918
Jun 29 13:41:24 mark2 ovos-core[67361]: 2024-06-29 13:41:24.393 - skills - ovos_bus_client.client.client:on_default_session_update:166 - DEBUG - synced default_session
Jun 29 13:41:24 mark2 ovos-core[67361]: 2024-06-29 13:41:24.438 - skills - ovos_bus_client.apis.ocp:__init__:876 - DEBUG - Created RADIO query: a song radio
Jun 29 13:41:24 mark2 ovos-core[67361]: 2024-06-29 13:41:24.576 - skills - ovos_bus_client.apis.ocp:register_events:935 - DEBUG - Registering Search Bus Events
Jun 29 13:41:24 mark2 ovos-core[67361]: 2024-06-29 13:41:24.596 - skills - ovos_bus_client.apis.ocp:handle_skill_search_start:948 - DEBUG - skill-ovos-local-media.openvoiceos is searching
Jun 29 13:41:24 mark2 ovos-core[67361]: 2024-06-29 13:41:24.603 - skills - ovos_bus_client.apis.ocp:handle_skill_response:982 - DEBUG - got 0 results from skill-ovos-local-media.openvoiceos
Jun 29 13:41:24 mark2 ovos-core[67361]: 2024-06-29 13:41:24.646 - skills - ovos_bus_client.apis.ocp:handle_skill_search_end:1015 - DEBUG - skill-ovos-local-media.openvoiceos finished search
Jun 29 13:41:25 mark2 ovos-core[67361]: 2024-06-29 13:41:25.148 - skills - ovos_bus_client.apis.ocp:handle_skill_search_end:1029 - INFO - Received search responses from all skills!
Jun 29 13:41:25 mark2 ovos-core[67361]: 2024-06-29 13:41:25.180 - skills - ovos_bus_client.apis.ocp:remove_events:941 - DEBUG - Removing Search Bus Events
Jun 29 13:41:25 mark2 ovos-core[67361]: 2024-06-29 13:41:25.181 - skills - ovos_core.intent_services.ocp_service:_execute_query:937 - DEBUG - OVOSCommonPlay falling back to MediaType.GENERIC
Jun 29 13:41:25 mark2 ovos-core[67361]: 2024-06-29 13:41:25.225 - skills - ovos_bus_client.apis.ocp:register_events:935 - DEBUG - Registering Search Bus Events
Jun 29 13:41:25 mark2 ovos-core[67361]: 2024-06-29 13:41:25.276 - skills - ovos_bus_client.apis.ocp:handle_skill_search_start:948 - DEBUG - skill-ovos-local-media.openvoiceos is searching
Jun 29 13:41:25 mark2 ovos-core[67361]: 2024-06-29 13:41:25.280 - skills - ovos_bus_client.apis.ocp:handle_skill_search_start:948 - DEBUG - skill-ovos-news.openvoiceos is searching
Jun 29 13:41:25 mark2 ovos-core[67361]: 2024-06-29 13:41:25.281 - skills - ovos_bus_client.apis.ocp:handle_skill_response:982 - DEBUG - got 0 results from skill-ovos-local-media.openvoiceos
Jun 29 13:41:25 mark2 ovos-core[67361]: 2024-06-29 13:41:25.318 - skills - ovos_bus_client.apis.ocp:handle_skill_search_end:1015 - DEBUG - skill-ovos-local-media.openvoiceos finished search
Jun 29 13:41:25 mark2 ovos-core[67361]: 2024-06-29 13:41:25.502 - skills - ovos_bus_client.apis.ocp:handle_skill_response:982 - DEBUG - got 0 results from skill-ovos-news.openvoiceos
Jun 29 13:41:25 mark2 ovos-core[67361]: 2024-06-29 13:41:25.510 - skills - ovos_bus_client.apis.ocp:handle_skill_search_end:1015 - DEBUG - skill-ovos-news.openvoiceos finished search
Jun 29 13:41:25 mark2 ovos-core[67361]: 2024-06-29 13:41:25.821 - skills - ovos_bus_client.apis.ocp:handle_skill_search_end:1029 - INFO - Received search responses from all skills!
Jun 29 13:41:25 mark2 ovos-core[67361]: 2024-06-29 13:41:25.830 - skills - ovos_bus_client.apis.ocp:remove_events:941 - DEBUG - Removing Search Bus Events
Jun 29 13:41:25 mark2 ovos-core[67361]: 2024-06-29 13:41:25.832 - skills - ovos_core.intent_services.ocp_service:_execute_query:944 - DEBUG - Returning 0 search results
Jun 29 13:41:25 mark2 ovos-core[67361]: 2024-06-29 13:41:25.833 - skills - ovos_core.intent_services.ocp_service:_search:894 - DEBUG - Got 0 results
Jun 29 13:41:25 mark2 ovos-core[67361]: 2024-06-29 13:41:25.834 - skills - ovos_core.intent_services.ocp_service:filter_results:824 - DEBUG - filtered 0 low confidence results
Jun 29 13:41:25 mark2 ovos-core[67361]: 2024-06-29 13:41:25.836 - skills - ovos_core.intent_services.ocp_service:filter_results:832 - DEBUG - filtered 0 wrong MediaType results
Jun 29 13:41:25 mark2 ovos-core[67361]: 2024-06-29 13:41:25.838 - skills - ovos_core.intent_services.ocp_service:_search:897 - DEBUG - Got 0 usable results

@JarbasAl JarbasAl merged commit fc37cd8 into dev Jun 29, 2024
9 checks passed
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants