fix/activation+session #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not activate/deactivate the skill if there was no change to Session (avoid bus spam) update session data so the skill already sees the skill as active, otherwise since it was async the Session was outdated in the intent handler
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Jun 20, 2024
companion to OpenVoiceOS/OVOS-workshop#212 update session data so the skill already sees the skill as active, otherwise since it was async the Session was outdated in the intent handler
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #212 +/- ##
======================================
Coverage ? 54.58%
======================================
Files ? 36
Lines ? 3972
Branches ? 0
======================================
Hits ? 2168
Misses ? 1804
Partials ? 0 ☔ View full report in Codecov by Sentry. |
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Jun 20, 2024
* fix/activation_session companion to OpenVoiceOS/OVOS-workshop#212 update session data so the skill already sees the skill as active, otherwise since it was async the Session was outdated in the intent handler * no ocp double activation * move dialog to the intent handler * fix tests * fix message.context * requirements.txt
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not activate/deactivate the skill if there was no change to Session (avoid bus spam)
update session data so the skill already sees the skill as active, otherwise since it was async the Session was outdated in the intent handler