fix/fallback_timeout_handling #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by using a killable_event we can abort fallbacks that timedout avoiding multiple answers closes OpenVoiceOS/ovos-core#389 also avoids sessions being able to kill each other's events, could be problematic in get_response and company
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Jun 18, 2024
by using a killable_event we can abort fallbacks that timedout avoiding multiple answers closes #389 needs OpenVoiceOS/OVOS-workshop#210
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #210 +/- ##
======================================
Coverage ? 54.56%
======================================
Files ? 36
Lines ? 3966
Branches ? 0
======================================
Hits ? 2164
Misses ? 1802
Partials ? 0 ☔ View full report in Codecov by Sentry. |
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Jun 18, 2024
* improve_fallback_timeout improves #389 but does not fix it allow up to 15 seconds by default for each fallback skill (previously 3) + make configurable log warnings on timeout * fix/fallback_timeout_handling by using a killable_event we can abort fallbacks that timedout avoiding multiple answers closes #389 needs OpenVoiceOS/OVOS-workshop#210 * fix tests * fix duplicated messages * Update requirements.txt * "max_skill_runtime"
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by using a killable_event we can abort fallbacks that timedout avoiding multiple answers
closes OpenVoiceOS/ovos-core#389
also avoids sessions being able to kill each other's events, could be problematic in get_response and company