Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/units_from_session #197

Merged
merged 2 commits into from
Apr 20, 2024
Merged

feat/units_from_session #197

merged 2 commits into from
Apr 20, 2024

Conversation

JarbasAl
Copy link
Member

add missing "magic properties" for session aware user preferences

needs OpenVoiceOS/ovos-bus-client#90

add missing "magic properties" for session aware user preferences

needs OpenVoiceOS/ovos-bus-client#90
@JarbasAl JarbasAl added the enhancement New feature or request label Apr 20, 2024
@JarbasAl JarbasAl requested a review from a team April 20, 2024 00:55
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (dev@056f3cb). Click here to learn what that means.

Files Patch % Lines
ovos_workshop/skills/ovos.py 50.00% 6 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #197   +/-   ##
======================================
  Coverage       ?   53.53%           
======================================
  Files          ?       36           
  Lines          ?     3814           
  Branches       ?        0           
======================================
  Hits           ?     2042           
  Misses         ?     1772           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit bece329 into dev Apr 20, 2024
9 checks passed
@JarbasAl JarbasAl deleted the feat/units_from_session branch April 20, 2024 23:17
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant