hack/high_cpu_usage

[JarbasAl]

maybe closes #151

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@1f5fa54). Click here to learn what that means.

Additional details and impacted files

@@          Coverage Diff           @@
##             dev     #176   +/-   ##
======================================
  Coverage       ?   54.20%           
======================================
  Files          ?       36           
  Lines          ?     3699           
  Branches       ?        0           
======================================
  Hits           ?     2005           
  Misses         ?     1694           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mikejgray]

Worth a try...can we have goldy test it on this branch before we merge it into dev? I'm concerned about far-reaching implications of always delaying it

[JarbasAl]

can also put it behind a flag that only docker container sets, instead of being a default, but lets see what @goldyfruit tests have to say

[j1nx]

Is this really tackling the problem?

I believe what @goldyfruit meant is that he uses multiple docker comtainers of which each container only runs one skill. The containers all run isolated, so each container only runs through this section once isn't it?

The problem, I believe comes from that when he boots, all those different containers are all started at once, so for the OS is looks similar as starting ovos-core multiple times at once, each of them loading one skill but any thread safe code within the conatiners doesn't know about threads in other containers. (? Assumption ?)

Not sure, you can fix this at the workshop level. Guess this needs to be solved on the OS level.

Or Python should be aware on a OS level of other python processes and the amount of threads.
Perhaps something like this;
https://docs.python.org/2/library/queue.html

But all that is out of my know how.

[goldyfruit]

It helps a bit but more skill container I will have more the load will be.

[goldyfruit]

Just retrieved without this PR and it seems better... Not sure why...