Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/get_response_session #149

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix/get_response_session #149

merged 1 commit into from
Nov 21, 2023

Conversation

JarbasAl
Copy link
Member

"skill.converse.get_response.enable/disable" messages should already include the new utterance_state in their emitted session

this PR updates the session before message is emitted to account for this, ensuring the updated session is present all the way

"skill.converse.get_response.enable/disable" messages should already include the new utterance_state in their emitted session

this PR updates the session before message is emitted to account for this, ensuring the updated session is present all the way
@JarbasAl JarbasAl added the bug Something isn't working label Nov 21, 2023
@JarbasAl JarbasAl requested a review from emphasize November 21, 2023 21:42
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (4f65ac5) 60.23% compared to head (c89e7ae) 59.56%.
Report is 14 commits behind head on dev.

Files Patch % Lines
ovos_workshop/skills/ovos.py 24.48% 37 Missing ⚠️
ovos_workshop/version.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #149      +/-   ##
==========================================
- Coverage   60.23%   59.56%   -0.67%     
==========================================
  Files          34       34              
  Lines        3347     3371      +24     
==========================================
- Hits         2016     2008       -8     
- Misses       1331     1363      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit dfac136 into dev Nov 21, 2023
8 of 9 checks passed
@JarbasAl JarbasAl deleted the fix/get_response_session branch November 21, 2023 22:23
This was referenced Dec 29, 2023
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant