Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows wait argument to be int value for seconds #146

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

jaredcobb
Copy link
Contributor

Changes

  • Allows the wait param to be either a bool or int
  • All previous defaults are backward compatible
  • Adds comments to the method signatures

@JarbasAl JarbasAl added the enhancement New feature or request label Nov 1, 2023
@JarbasAl JarbasAl requested a review from emphasize November 1, 2023 17:50
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (4f65ac5) 60.23% compared to head (b225211) 59.63%.
Report is 8 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #146      +/-   ##
==========================================
- Coverage   60.23%   59.63%   -0.60%     
==========================================
  Files          34       34              
  Lines        3347     3367      +20     
==========================================
- Hits         2016     2008       -8     
- Misses       1331     1359      +28     
Files Coverage Δ
ovos_workshop/version.py 0.00% <0.00%> (ø)
ovos_workshop/skills/ovos.py 70.83% <21.42%> (-2.10%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit 6a2a2ae into OpenVoiceOS:dev Nov 2, 2023
7 of 8 checks passed
This was referenced Dec 29, 2023
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants