Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mic listen message destination #141

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

emphasize
Copy link
Member

@emphasize emphasize commented Oct 6, 2023

Problem : confirm listening sound is not played with a message reply.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7d0142d) 60.25% compared to head (8dbd3e7) 60.24%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #141      +/-   ##
==========================================
- Coverage   60.25%   60.24%   -0.02%     
==========================================
  Files          34       34              
  Lines        3326     3325       -1     
==========================================
- Hits         2004     2003       -1     
  Misses       1322     1322              
Files Coverage Δ
ovos_workshop/skills/ovos.py 73.14% <100.00%> (-0.03%) ⬇️
ovos_workshop/version.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl added the bug Something isn't working label Oct 6, 2023
ovos_workshop/skills/ovos.py Outdated Show resolved Hide resolved
@emphasize emphasize requested a review from JarbasAl October 6, 2023 22:36
@JarbasAl JarbasAl merged commit 7cf8e4e into OpenVoiceOS:dev Oct 6, 2023
7 of 8 checks passed
This was referenced Dec 29, 2023
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants