Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/get_response_return_val #138

Merged
merged 3 commits into from
Oct 2, 2023
Merged

fix/get_response_return_val #138

merged 3 commits into from
Oct 2, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Oct 2, 2023

No description provided.

@JarbasAl JarbasAl added the bug Something isn't working label Oct 2, 2023
@JarbasAl JarbasAl requested a review from emphasize October 2, 2023 23:08
fix/get_response some more

skip tests that need rewriting

skip tests that need rewriting

skip tests that need rewriting

fix/get_response
@JarbasAl JarbasAl marked this pull request as ready for review October 2, 2023 23:16
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (c8d2afd) 55.67% compared to head (2a0c79b) 55.71%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #138      +/-   ##
==========================================
+ Coverage   55.67%   55.71%   +0.04%     
==========================================
  Files          34       34              
  Lines        3305     3308       +3     
==========================================
+ Hits         1840     1843       +3     
  Misses       1465     1465              
Files Coverage Δ
ovos_workshop/version.py 0.00% <0.00%> (ø)
ovos_workshop/skills/ovos.py 64.38% <8.47%> (+0.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit 171b545 into dev Oct 2, 2023
9 checks passed
@JarbasAl JarbasAl deleted the fix/get_response2 branch October 2, 2023 23:32
@JarbasAl JarbasAl changed the title fix/get_response fix/get_response_return_val Oct 3, 2023
This was referenced Dec 29, 2023
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant