Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/sounds_playback in ovos-audio #129

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Sep 5, 2023

@JarbasAl JarbasAl added the enhancement New feature or request label Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 18.18% and project coverage change: -0.22% ⚠️

Comparison is base (e659917) 58.32% compared to head (3b03b09) 58.10%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #129      +/-   ##
==========================================
- Coverage   58.32%   58.10%   -0.22%     
==========================================
  Files          33       33              
  Lines        3251     3268      +17     
==========================================
+ Hits         1896     1899       +3     
- Misses       1355     1369      +14     
Files Changed Coverage Δ
ovos_workshop/skills/base.py 76.17% <ø> (+0.03%) ⬆️
ovos_workshop/version.py 0.00% <0.00%> (ø)
ovos_workshop/skills/ovos.py 54.48% <11.11%> (-5.21%) ⬇️
ovos_workshop/skills/mycroft_skill.py 56.71% <75.00%> (+0.56%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ovos_workshop/skills/base.py Outdated Show resolved Hide resolved
@JarbasAl JarbasAl force-pushed the feat/sounds_playback_audio_service branch from 83e14c5 to 3b03b09 Compare September 19, 2023 20:13
@JarbasAl JarbasAl merged commit 8027bda into dev Sep 19, 2023
8 of 9 checks passed
@JarbasAl JarbasAl deleted the feat/sounds_playback_audio_service branch September 19, 2023 20:16
This was referenced Dec 29, 2023
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants