Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/converse_intents #12

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

NeonJarbas
Copy link
Contributor

@NeonJarbas NeonJarbas commented Nov 19, 2021

add support for .intent files in converse method

a new decorator can be used to define internal intent handlers

these intents only trigger after an initial interaction, essentially they are only follow up questions

class DogFactsSkill(OVOSSkill):

    @intent_handler("dog_facts.intent")
    def handle_intent(self, message):
        fact = "Dogs sense of smell is estimated to be 100,000 times more sensitive than humans"
        self.speak(fact)

    @conversational_intent("another_one.intent")
    def handle_followup_question(self, message):
        fact2 = "Dogs have a unique nose print,  making each one distinct and identifiable."
        self.speak(fact2)

NOTE: if these intents trigger, they are called INSTEAD of converse

ported from NeonGeckoCom/NeonCore#48

@JarbasAl JarbasAl requested a review from NeonDaniel November 19, 2021 09:35
@NeonDaniel
Copy link
Member

What's the relationship with conversational intents and intent layers?

@JarbasAl
Copy link
Member

different concepts, conversational intents replace the converse stage completely. Instead of using a lot of voc_match in converse you just define intents and do not need to change paradigm to implement the voice interaction

intent layers are regular intent groups the skill dev turns on/off whenever needed, they dont depend on converse at all. It is common to use converse to manipulate layers, but its just a use case not part of the design

@JarbasAl
Copy link
Member

marked as draft waiting for intent plugins

@NeonJarbas NeonJarbas marked this pull request as draft November 23, 2021 13:16
@JarbasAl JarbasAl added the enhancement New feature or request label Feb 25, 2022
@JarbasAl JarbasAl mentioned this pull request Oct 10, 2023
36 tasks
add support for .intent files in converse method

a new decorator can be used to define internal intent handlers
@JarbasAl JarbasAl force-pushed the feat/converse_intents branch from 2070014 to 52af7b1 Compare March 19, 2024 16:33
@JarbasAl JarbasAl marked this pull request as ready for review March 19, 2024 16:33
@JarbasAl JarbasAl changed the base branch from master to dev March 19, 2024 16:34
@JarbasAl JarbasAl requested review from emphasize, mikejgray and a team March 19, 2024 16:35
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 19.14894% with 38 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (dev@80deb75). Click here to learn what that means.

Files Patch % Lines
ovos_workshop/skills/ovos.py 17.94% 32 Missing ⚠️
ovos_workshop/decorators/__init__.py 25.00% 6 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev      #12   +/-   ##
======================================
  Coverage       ?   53.60%           
======================================
  Files          ?       36           
  Lines          ?     3785           
  Branches       ?        0           
======================================
  Hits           ?     2029           
  Misses         ?     1756           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit b027d87 into OpenVoiceOS:dev Mar 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants