Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for utils 0.0.38 #200

Closed
JarbasAl opened this issue May 4, 2024 · 2 comments · Fixed by #201
Closed

add support for utils 0.0.38 #200

JarbasAl opened this issue May 4, 2024 · 2 comments · Fixed by #201
Assignees
@NeonDaniel
Labels
packaging

Comments

@JarbasAl
Copy link
Member

JarbasAl commented May 4, 2024 •
edited
Loading

to go with ovos-core 0.0.8 we want to also allow the last stable ovos-utils 0.0.X version if possible

taken from OpenVoiceOS/ovos-core#449
@JarbasAl
Copy link
Member Author

JarbasAl commented May 4, 2024

i believe the only change needed is to wrap these imports with a try: except ImportError: and redeclare the enums here for compat

https://github.com/OpenVoiceOS/OVOS-workshop/blob/dev/ovos_workshop/skills/common_play.py#L17

https://github.com/OpenVoiceOS/OVOS-workshop/blob/dev/ovos_workshop/decorators/ocp.py#L2

@JarbasAl JarbasAl mentioned this issue May 4, 2024
Closed
@NeonDaniel
Copy link
Member

Dependency added in #172

@NeonDaniel NeonDaniel mentioned this issue May 6, 2024
Merged
NeonDaniel added a commit that referenced this issue May 6, 2024
@NeonDaniel
Update imports to support ovos-utils~=0.0.x with compat. warnings
e736282 
Closes #200
@NeonDaniel NeonDaniel mentioned this issue May 6, 2024
Merged
JarbasAl pushed a commit that referenced this issue May 8, 2024
@NeonDaniel
Update imports to support ovos-utils~=0.0.x with compat. warnings (#201)
e2b042d 
* Update imports to support ovos-utils~=0.0.x with compat. warnings
Closes #200

* Address review comments

* Add back missing imports

---------

Co-authored-by: Daniel McKnight <[email protected]>
@github-actions github-actions bot mentioned this issue Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NeonDaniel NeonDaniel

Labels
packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update imports to support ovos-utils~=0.0.x with compat. warnings OpenVoiceOS/OVOS-workshop
2 participants
@JarbasAl @NeonDaniel