Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit-test: Add Old expansion test on nix (EASYRSA_FORCE_SAFE_SSL) #1151

Merged
merged 1 commit into from
May 29, 2024

Conversation

TinCanTech
Copy link
Collaborator

@TinCanTech TinCanTech commented May 29, 2024

This forces the unit test to use the original sed expansion of openssl-easyrsa.cnf on Linux. This also forces use of escape_hazard().

@TinCanTech TinCanTech self-assigned this May 29, 2024
@TinCanTech TinCanTech added this to the v3.2.1 milestone May 29, 2024
@TinCanTech TinCanTech force-pushed the UT-add-old-expansion-nix-text branch from cf86eac to f62d625 Compare May 29, 2024 01:23
Use: EASYRSA_FORCE_SAFE_SSL and EASYRSA_LEGACY_SAFE_SSL

Signed-off-by: Richard T Bonhomme <[email protected]>
@TinCanTech TinCanTech force-pushed the UT-add-old-expansion-nix-text branch from f62d625 to 57a54fb Compare May 29, 2024 01:46
@TinCanTech
Copy link
Collaborator Author

TinCanTech commented May 29, 2024

The failure on Linux is identical to the failure on Windows:
escape_hazard() passes a file containing export to source_vars(), which fails because use of export is prohibited in a file to be sourced.

Because the file being sourced is generated internally, the simplest solution is to source the file directly, no validation of the data is required.

This will be addressed by 3277f51

@TinCanTech TinCanTech merged commit cf8f0b8 into OpenVPN:master May 29, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant