Remove unwanted code - Minor improvements #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Allows removal of the 'init-pki' section of 'install_data_to_pki()'. Signed-off-by: Richard T Bonhomme <[email protected]>
Only effects upgrade, up23_manage_upgrade_23() Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
If the openssl-easyrsa.cnf file fails to copy then try to create it using create_openssl_easyrsa_cnf(). If creating the file also fails then that is a fatal error. Signed-off-by: Richard T Bonhomme <[email protected]>
Signed-off-by: Richard T Bonhomme <[email protected]>
Because different commands have different cleanup requirements, this code reduces the success check to an if-then per command. Signed-off-by: Richard T Bonhomme <[email protected]>
TinCanTech
force-pushed
the
remove-unused-code
branch
from
eb63a2b to
0d12f4e
Compare
Signed-off-by: Richard T Bonhomme <[email protected]>
TinCanTech
changed the title
|
Follow-up: 52bac31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused code: Essentially, clean up the mess I made trying to control the
varsfile.Upgrade to
shellcheck0.9.0Other minor improvements.