Fix #679 where an NPE is thrown if the logback config doesn't have

a cyclic buffered appender to keep track of the last x log lines. Now it will throw a BadRequest exception with a useful message. Signed-off-by: Chris Larsen <[email protected]>
OpenTSDB · Feb 1, 2016 · d7fb09e · d7fb09e
1 parent 62cc3b7
commit d7fb09e
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/tsd/LogsRpc.java b/src/tsd/LogsRpc.java
@@ -93,6 +93,11 @@ public LogIterator() {
       final Logger root =
         (Logger) LoggerFactory.getLogger(Logger.ROOT_LOGGER_NAME);
       logbuf = (CyclicBufferAppender<ILoggingEvent>) root.getAppender("CYCLIC");
+      if (logbuf == null) {
+        throw new BadRequestException(
+            "No CyclicBufferAppender found. Please configure logback "
+            + "to store the latest log entries.");
+      }
     }
 
     public Iterator<String> iterator() {