Update getPollResult to avoid translate undefined #4473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bspekker
approved these changes
Dec 10, 2024
bastianjoel
reviewed
Dec 11, 2024
| @@ -171,6 +171,7 @@ export class TopicPdfService { | |||
| return true; | |||
| } | |||
| }) | |||
| .filter((singleResult: VotingResult) => !!singleResult.vote) | |||
There was a problem hiding this comment.
You could just do this check within the other filter call.
Also in line 179 there is logic to handle such cases. So either remove that logic or adjust it. I've committed a solution with the latter to you PR as it does not come with behavioral changes (Which your solution actually introduces).
There was a problem hiding this comment.
Yes, it is removed. I have looked at your comment and think, it could work that way.
|
@Elblinator , @bspekker please retest after @bastianjoel commit. |
reiterl
changed the title
|
@bastianjoel 's code seems to be okay. My filter code is no longer needed and is removed. |
Elblinator
approved these changes
Dec 11, 2024
bspekker
approved these changes
Dec 11, 2024
Elblinator
pushed a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4463
Exclude the singleVotingResult with vote equals undefined to avoid the translation of undefined.