Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add showReason method and handle p tags in reason #4354

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

reiterl
Copy link
Member

@reiterl reiterl commented Nov 14, 2024

Resolve #4345

@reiterl reiterl added the bug label Nov 14, 2024
@reiterl reiterl added this to the 4.2 milestone Nov 14, 2024
@reiterl
Copy link
Member Author

reiterl commented Nov 14, 2024

I looked at the os-editor. I didn't find the place, where the empty p is added in it. I used the simple solution to check showReason.

Copy link
Member

@bastianjoel bastianjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think your change is needed for backward compatibility I think we should also modify the editor to not output empty paragraphs. (For example to fix the motion form currently accepting empty motions)

@bastianjoel bastianjoel assigned reiterl and unassigned bastianjoel and Elblinator Nov 15, 2024
@reiterl reiterl requested a review from bastianjoel November 15, 2024 09:04
@reiterl reiterl assigned bastianjoel and Elblinator and unassigned reiterl Nov 15, 2024
@reiterl
Copy link
Member Author

reiterl commented Nov 15, 2024

Remove the 'p' tags, if getText() delivers nothing. In cleanOutput.

Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function test

@Elblinator Elblinator removed their assignment Nov 15, 2024
@bastianjoel bastianjoel merged commit 1a84c60 into OpenSlides:main Nov 15, 2024
2 checks passed
@reiterl reiterl deleted the 4345-empty-reason-not-displayed branch November 15, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Motion > reason: Headline permanently displayed
3 participants