-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix concurrent autoupdate single requests #4344
Fix concurrent autoupdate single requests #4344
Conversation
Why is it needed to build a collection of resolved received here? I don't understand the reason for this code. |
Because without this the (single) request would not resolve resulting in guard checks getting stuck. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reproduction from #4234 now consistently redirects you to the error?meetingId=2&error=Authorization%20Error
url
-> The redirect to the error page is better than the behaviour before, but is it possible to redirect to the remaining meeting with our current setup?
The reproduction from #4281 is still resulting in the same behaviour (only step 9 now just shows a normal login page)
If I understand correctly this is just #4235 which is explicitly not fixed here.
In that case I would suggest removing this issue from this PR. |
resolves #4234