Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent autoupdate single requests #4344

Merged

Conversation

bastianjoel
Copy link
Member

@bastianjoel bastianjoel commented Nov 12, 2024

resolves #4234

@luisa-beerboom luisa-beerboom removed their assignment Nov 13, 2024
@reiterl
Copy link
Member

reiterl commented Nov 14, 2024

Why is it needed to build a collection of resolved received here? I don't understand the reason for this code.

@bastianjoel
Copy link
Member Author

bastianjoel commented Nov 15, 2024

Because without this the (single) request would not resolve resulting in guard checks getting stuck.

Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reproduction from #4234 now consistently redirects you to the error?meetingId=2&error=Authorization%20Error url
-> The redirect to the error page is better than the behaviour before, but is it possible to redirect to the remaining meeting with our current setup?

The reproduction from #4281 is still resulting in the same behaviour (only step 9 now just shows a normal login page)

@Elblinator Elblinator assigned bastianjoel and unassigned Elblinator Nov 15, 2024
@bastianjoel
Copy link
Member Author

The reproduction from #4234 now consistently redirects you to the error?meetingId=2&error=Authorization%20Error url
-> The redirect to the error page is better than the behaviour before, but is it possible to redirect to the remaining meeting with our current setup?

If I understand correctly this is just #4235 which is explicitly not fixed here.

The reproduction from #4281 is still resulting in the same behaviour (only step 9 now just shows a normal login page)

In that case I would suggest removing this issue from this PR.

@Elblinator Elblinator merged commit 05b33aa into OpenSlides:main Nov 18, 2024
6 checks passed
@bastianjoel bastianjoel deleted the 4234-fix-redirect-on-lockout branch November 20, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix redirect from autopilot if a user is locked out
4 participants