Fix participant detail view without delegation #4336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisa-beerboom
approved these changes
Nov 11, 2024
| @@ -234,7 +234,7 @@ export class ParticipantDetailViewComponent extends BaseMeetingComponent { | |||
| // TODO: Open groups subscription | |||
| this.groups = this.groupRepo.getViewModelListWithoutSystemGroupsObservable(); | |||
|
|
|||
| this.disableExpandControl = this.user.vote_delegations_from(); | |||
| this.disableExpandControl = this.user?.hasVoteRightFromOthers ? this.user.vote_delegations_from() : []; | |||
There was a problem hiding this comment.
Wouldn't it suffice to rewrite vote_delegations_from so it returns [] if there are no delegations?
There was a problem hiding this comment.
Okay, I looked at the error message again, that looks like either the user or the meeting_user has not yet loaded at that point. Probably need to ensure that happens first or maybe add a cheeky little '?' after the offending variable, before calling vote_delegations_from. Your choice.
Elblinator
force-pushed
the
4335-fix-detail-view-without-delegations
branch
from
2b1a368 to
3e16107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clsoses #4335