Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of amendment from amendment #4312

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

Elblinator
Copy link
Member

closes #4191

@Elblinator Elblinator added the bug label Nov 1, 2024
@Elblinator Elblinator added this to the 4.2 milestone Nov 1, 2024
@Elblinator Elblinator requested review from bastianjoel, MSoeb and reiterl and removed request for MSoeb November 1, 2024 14:01
@Elblinator Elblinator assigned reiterl and unassigned MSoeb Nov 1, 2024
@Elblinator Elblinator marked this pull request as ready for review November 1, 2024 14:01
@Elblinator Elblinator requested a review from MSoeb November 4, 2024 07:32
@Elblinator Elblinator removed the request for review from bastianjoel November 5, 2024 09:59
Copy link
Member

@reiterl reiterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small remark.

Comment on lines +28 to +31

.insert {
text-decoration: underline !important;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmh, I haven't found the usage of this. Is this debug code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the missing underline if the previous amendment created a completely new paragraph
So no debug code :D

@reiterl reiterl removed their assignment Nov 5, 2024
Copy link
Member

@reiterl reiterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmh, thought about it some more.
Perhaps use @let to remove the code duplication.

Copy link
Member

@reiterl reiterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, that is better, I think.

@reiterl reiterl removed their assignment Nov 7, 2024
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@MSoeb MSoeb assigned Elblinator and unassigned bspekker and MSoeb Nov 18, 2024
@MSoeb MSoeb removed the request for review from bspekker November 18, 2024 10:56
@Elblinator Elblinator assigned MSoeb and unassigned Elblinator Nov 18, 2024
@MSoeb MSoeb merged commit af83540 into OpenSlides:main Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix display of amendment from amendment
5 participants