Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default field to subscriptions #4310

Closed
wants to merge 5 commits into from
Closed

Add default field to subscriptions #4310

wants to merge 5 commits into from

Conversation

Elblinator
Copy link
Member

@Elblinator Elblinator commented Oct 30, 2024 •
edited
Loading

unlink #4236

@Elblinator Elblinator added this to the 4.2 milestone Oct 30, 2024
@Elblinator Elblinator marked this pull request as ready for review October 30, 2024 16:47
@Elblinator Elblinator force-pushed the 4236-add-default-fields branch from fed2156 to c236d2b Compare November 1, 2024 07:59
@reiterl
Copy link
Member

reiterl commented Nov 1, 2024

I couldn't find the reason of the test failure, too.

@Elblinator Elblinator force-pushed the 4236-add-default-fields branch 2 times, most recently from 156cdd8 to 73fe090 Compare November 1, 2024 11:11
@Elblinator Elblinator force-pushed the 4236-add-default-fields branch from 73fe090 to 0ebbd8c Compare November 1, 2024 11:42
@Elblinator Elblinator removed the request for review from bspekker November 1, 2024 12:08
@Elblinator Elblinator assigned Elblinator and unassigned bspekker and bastianjoel Nov 1, 2024
@Elblinator Elblinator removed the request for review from bastianjoel November 7, 2024 08:35
@Elblinator Elblinator closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Elblinator Elblinator

Labels
clean up
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Elblinator @reiterl @bastianjoel @bspekker