-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Motion with amendments add icon and amendment number #4199
Motion with amendments add icon and amendment number #4199
Conversation
Notes: bottom needs to be bigger if a line inside of a paragraph is changed |
63f2335
to
63a10f8
Compare
b72bb03
to
357d6d7
Compare
.../pages/meetings/pages/motions/services/common/motion-format.service/motion-format.service.ts
Outdated
Show resolved
Hide resolved
.../pages/meetings/pages/motions/services/common/motion-format.service/motion-format.service.ts
Show resolved
Hide resolved
.../pages/meetings/pages/motions/services/common/motion-format.service/motion-format.service.ts
Outdated
Show resolved
Hide resolved
.../pages/meetings/pages/motions/services/common/motion-format.service/motion-format.service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two superfluous line numbers in projector:
-
Additional line number with empty line appears for first amendment if first amendment only changes up to line x in the motion and second amendment makes changes from line x+1 onwards.
-
Line number overlaps with conflict symbol if one amendment spans several paragraphs but the other one does not with the conflict only appearing in the second paragraph.
I removed the doubled line numbers |
436919e
to
af5910b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amendment numbers on projector use different font for italics than in the motion. This causes the colon to not be highlighted in gray completely.
Indication of change recommendations are missing. Sould say "Change recommendation" like it does for amendments without number and symbol.
closes part of #4159
The first part is not part of an enhancement but a bug in the motion projection