Reduce data sent by shared worker #4066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrenkert
approved these changes
Sep 9, 2024
24 tasks
bastianjoel
force-pushed
the
autoupdate-reduce-data-movement
branch
from
151e548 to
4a43af8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1664
With this PR data is sent by stream and not by subscription anymore. This reduces the updates to the view model stores and data sent between shared worker and client.
Also the debug outputs are now containing information about which streams are handled together.
As a side effect this makes data received by
viewModelObservableandviewModelListObservablemuch more predictable. #4024 is containing a similar solution for that reason which will be improved by this PR.Please do not merge before #4024