Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable gender field #4027

Merged
merged 29 commits into from
Sep 27, 2024
Merged

Customizable gender field #4027

merged 29 commits into from
Sep 27, 2024

Conversation

reiterl
Copy link
Member

@reiterl reiterl commented Aug 15, 2024

Resolve #3803

Work in Progress, added internal logic and the list and dialog, the genders/gender fields still need to be replaced in the different code positions.

Needs an updated versions of:[

@reiterl reiterl added this to the 4.2 milestone Aug 15, 2024
@reiterl reiterl self-assigned this Aug 15, 2024
@reiterl
Copy link
Member Author

reiterl commented Sep 9, 2024

Add subscription, relations, and AppConfig. Open are still filter, sort and import, and perhaps delete prompt.

@reiterl reiterl marked this pull request as ready for review September 11, 2024 06:19
@reiterl
Copy link
Member Author

reiterl commented Sep 11, 2024

@Elblinator
Copy link
Member

changed requirement in the CR:

  • the checkboxes should stay where they are
  • if a default gender is selected then the delete option is (with an explanatory tip) disabled

@reiterl
Copy link
Member Author

reiterl commented Sep 25, 2024

Worked on the multiselect CR, I have excluded the edit /delete actions, disable the menu delete button if default genders are selected, and add a tooltip then.

@reiterl reiterl requested a review from Elblinator September 25, 2024 13:14
@reiterl reiterl assigned bastianjoel, Elblinator and MSoeb and unassigned reiterl Sep 25, 2024
@Elblinator Elblinator removed the request for review from MSoeb September 26, 2024 08:42
@bastianjoel bastianjoel assigned reiterl and unassigned bastianjoel Sep 26, 2024
@reiterl
Copy link
Member Author

reiterl commented Sep 26, 2024

Some code cleanup and change of the title.

@reiterl reiterl requested a review from bastianjoel September 26, 2024 11:33
@reiterl reiterl assigned bastianjoel and unassigned reiterl Sep 26, 2024
@Elblinator
Copy link
Member

please leave merging to @rrenkert or @Elblinator
This PR and some others need merging in the correct order

@rrenkert rrenkert enabled auto-merge (squash) September 27, 2024 14:17
@rrenkert rrenkert merged commit f097ed2 into OpenSlides:main Sep 27, 2024
2 checks passed
@reiterl reiterl deleted the 3803-gender branch September 30, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add customisable gender
5 participants