Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new forward parameter for CRs #3977

Conversation

bastianjoel
Copy link
Member

resolves #3837

@bastianjoel bastianjoel requested a review from Elblinator August 5, 2024 14:09
@bastianjoel bastianjoel changed the title Add new forward parameter for crs Add new forward parameter for CRs Aug 5, 2024
@Elblinator Elblinator linked an issue Aug 6, 2024 that may be closed by this pull request
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly it the client should send the original Motion in the payload. The client is currently sending the originalMotion plus change recommendations

A forwarded motion is not correctly forwarded/displayed:

origin_motion:
Screenshot_20240807_115436

forwarded_motion:
Screenshot_20240807_115503

payload:

[
  {
    "action": "motion.create_forwarded",
    "data": [
      {
        "meeting_id": 5,
        "use_original_submitter": true,
        "use_original_number": true,
        "with_amendments": true,
        "with_change_recommendations": true,
        "origin_id": 26,
        "title": "More test motions",
        "reason": "",
        "text": "<p>Test jkljl</p><p>TSt</p><p>Monkey</p>"
      }
    ]
  }
]

@Elblinator Elblinator assigned bastianjoel and unassigned Elblinator Aug 7, 2024
@Elblinator
Copy link
Member

Also I just realised that with_amendments could be false?
if this describes the motion it should be false (the motion doesn't have amendments)
if it describes what the backend should do in case an amendment exists then it should be true

@bastianjoel bastianjoel force-pushed the 3837-enhance-motion-forward branch from 9c19d98 to ae15b31 Compare August 14, 2024 09:18
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue with if the title had a change recommendation

The forwarded motion has the title from the change recommendation

Original motion:
Screenshot_20240814_150954

Forwarded motion:
Screenshot_20240814_151117

@Elblinator Elblinator assigned bastianjoel and unassigned Elblinator Aug 14, 2024
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to also save the origin title

@Elblinator Elblinator merged commit 55d1590 into OpenSlides:feature/motion-forward Aug 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance motion forward dialog part 2
2 participants