Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow committee admin personal info edit #3833

Conversation

luisa-beerboom
Copy link
Member

@luisa-beerboom luisa-beerboom commented Jul 9, 2024

@luisa-beerboom luisa-beerboom added this to the 4.2 milestone Jul 9, 2024
@luisa-beerboom luisa-beerboom self-assigned this Jul 9, 2024
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meeting-admins:
If participant Ann is an admin in meeting A and B and participant Ben is a participant in only these two meetings then Ann should be able to change the personal information from Ben, but the personal information fields are currently disabled in this scenario.
If Ben is only in one of these meetings then Ann can change the personal information currently

Committee admin:
A committee admin can change the initial password but cannot see the password, the committee-admin should be able to change the password. The committee admin should also be able to see the password (tthis is an autoupdate-service issue see -> OpenSlides/openslides-autoupdate-service#965) (edited 12.07.24)

If the user edit page is open and the page is reloaded then the following Error is thrown in the console

ERROR TypeError: Cannot read properties of null (reading 'enable')
    at user-detail-view.component.ts:283:73

Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a committee-admin>
Please change the visible options in the three dot menu:
Please remove-hide the merge accounts -option

@luisa-beerboom
Copy link
Member Author

Meeting-admins:
If participant Ann is an admin in meeting A and B and participant Ben is a participant in only these two meetings then Ann should be able to change the personal information from Ben, but the personal information fields are currently disabled in this scenario.
If Ben is only in one of these meetings then Ann can change the personal information currently

That is indeed an inconsistency, however it was not part of the issue. If you want this changed, we'll have to discuss it with the appropriate people and define the requirements for both the backend and the client.
Regardless, I would suggest doing that separately after this issue is merged

@Elblinator
Copy link
Member

Meeting-admins:
If participant Ann is an admin in meeting A and B and participant Ben is a participant in only these two meetings then Ann should be able to change the personal information from Ben, but the personal information fields are currently disabled in this scenario.
If Ben is only in one of these meetings then Ann can change the personal information currently

That is indeed an inconsistency, however it was not part of the issue. If you want this changed, we'll have to discuss it with the appropriate people and define the requirements for both the backend and the client. Regardless, I would suggest doing that separately after this issue is merged

that is part of the bug issue #3806
see nr 2 of wanted behaviour:

write permission: A meeting admin has write permission for personal information if they are an admin in ALL meetings in which a user is also a participant

@luisa-beerboom
Copy link
Member Author

Meeting-admins:
If participant Ann is an admin in meeting A and B and participant Ben is a participant in only these two meetings then Ann should be able to change the personal information from Ben, but the personal information fields are currently disabled in this scenario.
If Ben is only in one of these meetings then Ann can change the personal information currently

That is indeed an inconsistency, however it was not part of the issue. If you want this changed, we'll have to discuss it with the appropriate people and define the requirements for both the backend and the client. Regardless, I would suggest doing that separately after this issue is merged

that is part of the bug issue #3806 see nr 2 of wanted behaviour:

write permission: A meeting admin has write permission for personal information if they are an admin in ALL meetings in which a user is also a participant

That has never been a requirement before. It is therefore a feature request.

@Elblinator Elblinator removed their assignment Jul 11, 2024
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with the client and backend and it works fine

If the code is alright, then the prs can be merge imo.
-> I think these PRs can be merged without the autoupdate-service issue, but that issue should still be implemented soon

@Elblinator Elblinator removed their assignment Jul 12, 2024
luisa-beerboom and others added 2 commits July 15, 2024 14:21
…rticipant-detail/components/participant-detail-view/participant-detail-view.component.ts

Co-authored-by: Bastian Rihm <[email protected]>
@Elblinator Elblinator enabled auto-merge (squash) July 15, 2024 12:23
@Elblinator Elblinator merged commit 0772be9 into OpenSlides:main Jul 15, 2024
2 checks passed
@peb-adr peb-adr mentioned this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meeting admin: personal user data issue Allow committee admins to change personal information
3 participants