Mdc migration chip, button, menu, table, checkbox and list #3706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should maybe replace the chips with an custom component. |
This was referenced May 29, 2024
Closed
I did this on purpose because I thought the contrast is quite bad and did not notice that it was black previously. The presence button uses a transparent icon and I cannot change it easily there. Should I change it back to black or is it okay as it is now? |
bastianjoel
force-pushed
the
2934-rest
branch
2 times, most recently
from
17a5262 to
e9b6412
Compare
Merged
Elblinator
approved these changes
Jul 11, 2024
reiterl
reviewed
Jul 11, 2024
client/src/app/site/modules/chip-select/components/chip-select/chip-select.component.html
Show resolved
Hide resolved
...ages/meeting-settings-group-detail/components/allocation-list/allocation-list.component.html
Show resolved
Hide resolved
...nents/meeting-settings-group-detail-field/meeting-settings-group-detail-field.component.html
Show resolved
Hide resolved
...jectors/modules/projector-detail/components/projector-detail/projector-detail.component.html
Show resolved
Hide resolved
...jectors/modules/projector-detail/components/projector-detail/projector-detail.component.html
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2934
closes #3694
closes #3696
closes #3703