Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new styling #3700

Merged
merged 2 commits into from
May 30, 2024
Merged

Fix new styling #3700

merged 2 commits into from
May 30, 2024

Conversation

Elblinator
Copy link
Member

closes #3699
The motion-detail view is fixed with this change. I do not know where else this was affected, please test accordingly

@Elblinator Elblinator added this to the 4.2 milestone May 24, 2024
@Elblinator Elblinator marked this pull request as ready for review May 24, 2024 12:47
@luisa-beerboom luisa-beerboom removed their assignment May 27, 2024
MSoeb
MSoeb approved these changes May 29, 2024
View reviewed changes
Copy link

@MSoeb MSoeb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

Further information what is also affected:

  • election detail view
  • workflow detail view
  • category detail view
  • participant group permission overview
  • user detail view
  • history
  • Autoupdate layout looks also fine again. Not sure why it looks normal again with this PR.

MSoeb
MSoeb requested changes May 29, 2024
View reviewed changes
Copy link

@MSoeb MSoeb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a small issue. Have to revert my approval. The color status boxes, for example in the workflow or in the category, have changed their position slightly. The boxes are not aligned in the center.

Example: Box 'angenommen' is not centered.
image

@rrenkert rrenkert assigned Elblinator and unassigned MSoeb May 29, 2024
@Elblinator
Copy link
Member Author

This is not a new bug, please create a new issue for this

@Elblinator
Copy link
Member Author

Elblinator commented May 29, 2024 •
edited
Loading

This bug was already in main
I created it's own Issue for that:
#3710

@Elblinator Elblinator assigned MSoeb and unassigned Elblinator May 29, 2024
@Elblinator Elblinator requested a review from MSoeb May 29, 2024 14:31
MSoeb
MSoeb approved these changes May 30, 2024
View reviewed changes
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

@MSoeb MSoeb merged commit 157edfe into OpenSlides:main May 30, 2024
3 checks passed
openslides-automation bot pushed a commit that referenced this pull request May 30, 2024
@Elblinator
Fix new styling (#3700)
2536c97
MSoeb pushed a commit that referenced this pull request May 31, 2024
@openslides-automation
Fix new styling (#3700) (#3721)
79c2819
@Elblinator Elblinator deleted the 3699-detail-view-appearances branch August 2, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSoeb MSoeb MSoeb approved these changes

@luisa-beerboom luisa-beerboom luisa-beerboom approved these changes

@emanuelschuetze emanuelschuetze emanuelschuetze approved these changes

Assignees

@MSoeb MSoeb

Labels
bug staging ui
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Fix appearance from different headers (H1, H3-H6)
5 participants
@Elblinator @emanuelschuetze @luisa-beerboom @MSoeb @rrenkert