-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update chyron, add agenda item and new chyron type #3691
Conversation
It doesn't include the new colors for the agenda item. |
The needed colour picker still needs to be implemented in the backend: OpenSlides/openslides-backend#2437 |
Backend in OpenSlides/openslides-backend#2451 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
In projector edit dialog: please move the colour picker for chyron_background_color_2 below chyron_font_color
-
New chyron: please hide comma when the speaker is not talking with a structure level:
-
Please change the Toggle button to a Hide button
-
If the chyron is already projected (in the current projector) and the projection dialog is opened again, then the correct radio-buttons and checkbox should be preselected (e.g. if the new chyron and the agenda item are already projected then the dialog should have these options preselected)
-
If there is no current speaker then the chyron should be hidden
I have done most points of the change request, unless the pre-configuration of the projection dialog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed with @emanuelschuetze and @MSoeb:
UI-change:
- There should be no line between the two chyrons
- for new chyron and the agenda: line-height should be changed to 1.25
- for new chyron and the agenda: the chyrons should always have margin-right of 50px (the chyrons should not touch the end of the projector)
- only for the agenda: the font-size should be 24 (it was 28 before)
- only for the agenda: padding-right should be 18px (like padding-left is already)
Bugs:
- The
Topic/Motion numbers are not being projected, only the titles; The numbers should be projected as well - Activating the chyron on any projector Always activates the chyron on the reference projector; the chyron should only be activated of the projector which detail view we activate the chyron from
- Currently the chyron can only be activated in one combination at a time (e.g. new chyron and agenda item), activating the chyron in a different combination on a different projector deactivates the first combination; if possible can the different projections be independent from each other?
...mponents/current-speaker-chyron-slide/components/current-speaker-chyron-slide.component.scss
Outdated
Show resolved
Hide resolved
@bastianjoel Please checkout my changes and continue there on Tuesday. |
Needs OpenSlides/openslides-backend#2464 now. |
Resolve #3655
Needs autoupdate service pull request: OpenSlides/openslides-autoupdate-service#935