Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update chyron, add agenda item and new chyron type #3691

Merged
merged 15 commits into from
Jun 5, 2024

Conversation

reiterl
Copy link
Member

@reiterl reiterl commented May 22, 2024

Resolve #3655

Needs autoupdate service pull request: OpenSlides/openslides-autoupdate-service#935

@reiterl reiterl added enhancement General enhancement which is neither bug nor feature los-extension labels May 22, 2024
@reiterl reiterl self-assigned this May 22, 2024
@reiterl
Copy link
Member Author

reiterl commented May 22, 2024

It doesn't include the new colors for the agenda item.

@Elblinator
Copy link
Member

The needed colour picker still needs to be implemented in the backend: OpenSlides/openslides-backend#2437

@bastianjoel bastianjoel assigned bastianjoel and unassigned reiterl May 29, 2024
@reiterl reiterl marked this pull request as ready for review May 29, 2024 11:17
@luisa-beerboom luisa-beerboom removed their assignment May 29, 2024
@luisa-beerboom
Copy link
Member

Backend in OpenSlides/openslides-backend#2451

Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In projector edit dialog: please move the colour picker for chyron_background_color_2 below chyron_font_color

  • New chyron: please hide comma when the speaker is not talking with a structure level:
    Screenshot_20240529_152847

  • Please change the Toggle button to a Hide button

  • If the chyron is already projected (in the current projector) and the projection dialog is opened again, then the correct radio-buttons and checkbox should be preselected (e.g. if the new chyron and the agenda item are already projected then the dialog should have these options preselected)

  • If there is no current speaker then the chyron should be hidden

@Elblinator Elblinator assigned reiterl and unassigned Elblinator May 29, 2024
@reiterl
Copy link
Member Author

reiterl commented May 30, 2024

I have done most points of the change request, unless the pre-configuration of the projection dialog.
I have no idea, how to fix this. I leave it to @bastianjoel

@reiterl reiterl requested a review from Elblinator May 30, 2024 11:13
@reiterl reiterl assigned bastianjoel and unassigned reiterl May 30, 2024
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with @emanuelschuetze and @MSoeb:

UI-change:

  • There should be no line between the two chyrons
  • for new chyron and the agenda: line-height should be changed to 1.25
  • for new chyron and the agenda: the chyrons should always have margin-right of 50px (the chyrons should not touch the end of the projector)
  • only for the agenda: the font-size should be 24 (it was 28 before)
  • only for the agenda: padding-right should be 18px (like padding-left is already)

Bugs:

  • The Topic/Motion numbers are not being projected, only the titles; The numbers should be projected as well
  • Activating the chyron on any projector Always activates the chyron on the reference projector; the chyron should only be activated of the projector which detail view we activate the chyron from
  • Currently the chyron can only be activated in one combination at a time (e.g. new chyron and agenda item), activating the chyron in a different combination on a different projector deactivates the first combination; if possible can the different projections be independent from each other?

@Elblinator Elblinator assigned reiterl and unassigned bastianjoel May 31, 2024
@reiterl reiterl assigned bastianjoel and unassigned reiterl May 31, 2024
@reiterl
Copy link
Member Author

reiterl commented May 31, 2024

@bastianjoel Please checkout my changes and continue there on Tuesday.

@bastianjoel
Copy link
Member

Needs OpenSlides/openslides-backend#2464 now.

@bastianjoel bastianjoel merged commit c074235 into OpenSlides:main Jun 5, 2024
2 checks passed
@reiterl reiterl deleted the 3655-chyron-add-agenda branch June 10, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancement which is neither bug nor feature los-extension staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chyron enhancement: add agenda item
6 participants