Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add member number #3654

Merged
merged 10 commits into from
May 29, 2024
Merged

Add member number #3654

merged 10 commits into from
May 29, 2024

Conversation

reiterl
Copy link
Member

@reiterl reiterl commented May 8, 2024

@reiterl reiterl requested review from bastianjoel and Elblinator May 8, 2024 10:43
@reiterl reiterl added the waiting Waiting for some other PR/feature; more details in comments label May 8, 2024
@reiterl
Copy link
Member Author

reiterl commented May 13, 2024

Add export of member number and update the accounts export example file.

@Elblinator Elblinator assigned reiterl and unassigned bastianjoel May 14, 2024
@reiterl reiterl removed their assignment May 15, 2024
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the member_number to the participant export and the example file from the participant import

in participant-import change the preview title from 'member_number' to 'Member number'

@Elblinator Elblinator assigned reiterl and unassigned Elblinator May 16, 2024
@reiterl
Copy link
Member Author

reiterl commented May 16, 2024

Add the member number to participant export/import. You need an updated version of the backend pr to test it.

@reiterl reiterl requested a review from Elblinator May 16, 2024 10:11
@reiterl reiterl assigned Elblinator and unassigned reiterl May 16, 2024
@Elblinator
Copy link
Member

My approve was premature, please wait

Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the Member number to the account filter

@Elblinator Elblinator removed their assignment May 21, 2024
@reiterl reiterl requested a review from Elblinator May 21, 2024 08:30
@reiterl reiterl assigned Elblinator and unassigned reiterl May 21, 2024
@reiterl
Copy link
Member Author

reiterl commented May 21, 2024

Waiting on the backend/meta prs to be merged.

@bastianjoel bastianjoel removed the waiting Waiting for some other PR/feature; more details in comments label May 28, 2024
@bastianjoel bastianjoel assigned reiterl and unassigned Elblinator May 28, 2024
@bastianjoel
Copy link
Member

When creating accounts on orga level an error This member_number is forbidden is displayed.

@bastianjoel
Copy link
Member

@Elblinator have you tested removing a member number from a user?

@Elblinator
Copy link
Member

Removing a member number results in the same snackbar Error This member_number is forbidden

@Elblinator Elblinator added waiting Waiting for some other PR/feature; more details in comments and removed waiting Waiting for some other PR/feature; more details in comments labels May 28, 2024
@reiterl
Copy link
Member Author

reiterl commented May 29, 2024

Needs OpenSlides/openslides-backend#2450 to work.

@reiterl reiterl requested review from bastianjoel and Elblinator May 29, 2024 07:21
@reiterl reiterl assigned bastianjoel and Elblinator and unassigned reiterl May 29, 2024
@reiterl reiterl added the waiting Waiting for some other PR/feature; more details in comments label May 29, 2024
@bastianjoel bastianjoel removed their assignment May 29, 2024
@reiterl reiterl removed the waiting Waiting for some other PR/feature; more details in comments label May 29, 2024
@rrenkert rrenkert merged commit 2d57c04 into OpenSlides:main May 29, 2024
2 checks passed
@reiterl reiterl deleted the add-member-number-6759 branch May 30, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants