Fix too many updates for meetingSettingsService.get() #3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elblinator
requested review from
MSoeb
and removed request for
bastianjoel and
MSoeb
Elblinator
force-pushed
the
3621-cleanup-subscriptions
branch
from
0602cbf to
f77e85c
Compare
bastianjoel
approved these changes
Apr 30, 2024
bastianjoel
requested changes
May 2, 2024
| @@ -25,7 +25,9 @@ export class MeetingSettingsService { | |||
| this.activeMeetingService.meetingObservable.subscribe(meeting => { | |||
| if (meeting) { | |||
| for (const key of Object.keys(this.settingSubjects)) { | |||
| this.settingSubjects[key].next(meeting[key as keyof ViewMeeting]); | |||
| if (!(this.settingSubjects[key].getValue() === meeting[key as keyof ViewMeeting])) { | |||
There was a problem hiding this comment.
Suggested change
| if (!(this.settingSubjects[key].getValue() === meeting[key as keyof ViewMeeting])) { | |
| if (this.settingSubjects[key].getValue() !== meeting[key as keyof ViewMeeting]) { |
bastianjoel
approved these changes
May 3, 2024
|
waiting for @rrenkert |
rrenkert
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3631
reverts part of #3621