-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide empty space if three dot menu is not shown #3590
Merged
rrenkert
merged 6 commits into
OpenSlides:main
from
Elblinator:3587-adjust-three-dot-menu
May 22, 2024
Merged
Hide empty space if three dot menu is not shown #3590
rrenkert
merged 6 commits into
OpenSlides:main
from
Elblinator:3587-adjust-three-dot-menu
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrenkert
approved these changes
Apr 23, 2024
bastianjoel
requested changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer a cleaner solution for this.
For example it should not be too hard to extend scrolling-table-cell.directive.ts
to accept observables.
bastianjoel
requested changes
May 21, 2024
client/src/app/ui/modules/scrolling-table/directives/scrolling-table-cell.directive.ts
Show resolved
Hide resolved
bastianjoel
requested changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No
bastianjoel
approved these changes
May 21, 2024
bastianjoel
approved these changes
May 21, 2024
rrenkert
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3587
I removed the check for the ownPage (and set it to false always) to hide the option to change own password at all at this specific place.
The previous behaviour seemed unintuitive. (Only account/organization admins got the option to change their own password at this place. these admins were not allowed to update participants in the meeting in question)
Note: Users are still able to change their own password via the my profile dialog