Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide empty space if three dot menu is not shown #3590

Merged
merged 6 commits into from
May 22, 2024

Conversation

Elblinator
Copy link
Member

closes #3587

I removed the check for the ownPage (and set it to false always) to hide the option to change own password at all at this specific place.
The previous behaviour seemed unintuitive. (Only account/organization admins got the option to change their own password at this place. these admins were not allowed to update participants in the meeting in question)
Note: Users are still able to change their own password via the my profile dialog

@Elblinator Elblinator added the bug label Apr 19, 2024
@Elblinator Elblinator added this to the 4.2 milestone Apr 19, 2024
@Elblinator Elblinator requested review from bastianjoel and MSoeb April 19, 2024 10:44
@Elblinator Elblinator marked this pull request as ready for review April 19, 2024 10:44
@Elblinator Elblinator assigned rrenkert and unassigned MSoeb Apr 22, 2024
@Elblinator Elblinator requested review from rrenkert and removed request for MSoeb April 22, 2024 14:32
@rrenkert rrenkert removed their assignment Apr 23, 2024
Copy link
Member

@bastianjoel bastianjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a cleaner solution for this.

For example it should not be too hard to extend scrolling-table-cell.directive.ts to accept observables.

@Elblinator Elblinator requested a review from bastianjoel May 21, 2024 13:11
@Elblinator Elblinator assigned rrenkert and unassigned Elblinator May 21, 2024
Copy link
Member

@bastianjoel bastianjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

@Elblinator Elblinator requested a review from bastianjoel May 21, 2024 14:48
@Elblinator Elblinator assigned bastianjoel and unassigned Elblinator May 21, 2024
@bastianjoel bastianjoel self-requested a review May 21, 2024 15:09
@bastianjoel bastianjoel removed their assignment May 21, 2024
@rrenkert rrenkert merged commit 8d86099 into OpenSlides:main May 22, 2024
3 checks passed
@Elblinator Elblinator deleted the 3587-adjust-three-dot-menu branch August 2, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix/Adjust participant-list three-dot menu
4 participants