Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscription for submitter in agenda #3523

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

Elblinator
Copy link
Member

closes #3515

@Elblinator Elblinator added the bug label Apr 10, 2024
@Elblinator Elblinator added this to the 4.2 milestone Apr 10, 2024
@Elblinator Elblinator marked this pull request as ready for review April 10, 2024 08:28
@Elblinator Elblinator requested a review from MSoeb April 10, 2024 08:28
@Elblinator Elblinator requested a review from bastianjoel April 10, 2024 08:28
@bastianjoel bastianjoel changed the title Add subscription for submitter in agena Add subscription for submitter in agenda Apr 10, 2024
Comment on lines 44 to 45
export const AGENDA_LIST_ITEM_SUBSCRIPTION = `agenda_list`;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why move this?

Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a change: An agenda list loading error appears. Showed it @Elblinator .

@Elblinator Elblinator assigned Elblinator and unassigned bastianjoel and MSoeb Apr 10, 2024
@MSoeb MSoeb self-requested a review April 10, 2024 13:10
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes has been tested. Works as it should.

@Elblinator Elblinator assigned bastianjoel and unassigned Elblinator Apr 10, 2024
@Elblinator Elblinator requested a review from bastianjoel April 10, 2024 13:27
@Elblinator Elblinator enabled auto-merge (squash) April 10, 2024 13:46
@Elblinator Elblinator merged commit dcb6515 into OpenSlides:main Apr 10, 2024
2 checks passed
@Elblinator Elblinator deleted the 3515-submitter-subscription branch April 24, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agenda: Submitters are not loaded until motions has been opened
3 participants