Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix projection of LoS #3439

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Fix projection of LoS #3439

merged 2 commits into from
Mar 25, 2024

Conversation

luisa-beerboom
Copy link
Member

@luisa-beerboom luisa-beerboom added this to the 4.2 milestone Mar 14, 2024
Elblinator
Elblinator requested changes Mar 15, 2024
View reviewed changes
Copy link
Member

@Elblinator Elblinator left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed another problem with the projected LoS:
Please let only a selected structure level be displayed.
Example: If Kim has two structure levels then both structure levels are currently projected, even if one or none is selected.
Note: The display of all structure levels is however correct when the structure levels are not connected with the countdowns

And please change the distance from class=nextSpeakers back to margin-top: 20px !important;
Your change with the interposed-question class is enough :)

@luisa-beerboom
Copy link
Member Author

Sorry, I missed another problem with the projected LoS: Please let only a selected structure level be displayed. Example: If Kim has two structure levels then both structure levels are currently projected, even if one or none is selected. Note: The display of all structure levels is however correct when the structure levels are not connected with the countdowns

Created OpenSlides/openslides-autoupdate-service#895 to deal with that.
I think that can be handled separately from this PR though and I am probably not going to be able to handle this in a reasonable amount of time, please prioritize that issue yourself

@Elblinator Elblinator merged commit 58f9f14 into OpenSlides:main Mar 25, 2024
3 checks passed
peb-adr added a commit that referenced this pull request Mar 27, 2024
@peb-adr
Merge staging/4.1.6 into stable/4.1.x. Update 20240327
5e73ddb 
* commit 'df84ffb4f5c886f426c24a29eae94362272d672a':
  Add motion list has identical motion filter (#3482) (#3484)
  Update meta repository (#3474)
  Fix projection for users without structure level (#3473)
  Fix projection of LoS (#3439)
  Improve mandat swap (#3463)
  PDF export: Add option 'Show only changed paragraph' (#3468)
  Fix style of submission date icons (#3458)
  Hide unneeded scrollbar in file list (#3449)
  Bump follow-redirects from 1.15.4 to 1.15.6 in /client (#3446)
  Bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /client (#3469)
  Fix motions list without projector  permission (#3467)
  Update meta repository (#3438)
  Hide contribution numbering with new setting (#3435)
  Enhance meeting settings (#3357)
  Update translations (#3451)
  Add new options for editing speaking time (#3419)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elblinator Elblinator Elblinator approved these changes

@bastianjoel bastianjoel bastianjoel approved these changes

Assignees

@Elblinator Elblinator

Labels
bug los-extension
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Fix projection of LoS
3 participants
@luisa-beerboom @bastianjoel @Elblinator