Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change display of identical motions #3425

Merged
merged 11 commits into from
Mar 15, 2024
Merged

Change display of identical motions #3425

merged 11 commits into from
Mar 15, 2024

Conversation

reiterl
Copy link
Member

@reiterl reiterl commented Mar 12, 2024

Resolve #3418

@reiterl reiterl added the enhancement General enhancement which is neither bug nor feature label Mar 12, 2024
@reiterl reiterl added this to the 4.2 milestone Mar 12, 2024
Elblinator
Elblinator requested changes Mar 12, 2024
View reviewed changes
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a comma in between the different motions/amendments

@Elblinator Elblinator assigned reiterl and unassigned Elblinator Mar 12, 2024
@reiterl
Copy link
Member Author

reiterl commented Mar 13, 2024

Who did say something about commas in the issue? No one.

@reiterl
Copy link
Member Author

reiterl commented Mar 13, 2024

Add the commas to the identical motions list.

@reiterl reiterl requested a review from Elblinator March 13, 2024 08:53
@reiterl reiterl assigned bastianjoel and Elblinator and unassigned reiterl Mar 13, 2024
@reiterl reiterl requested a review from jsangmeister March 13, 2024 09:25
@reiterl reiterl assigned jsangmeister and unassigned reiterl and bastianjoel Mar 13, 2024
@jsangmeister jsangmeister assigned reiterl and unassigned jsangmeister Mar 13, 2024
@emanuelschuetze
Copy link
Member

The layout should be improved:

  • use midpoints instead of comma
  • move new metadata block above category (see arrow in screenshot)
    image

emanuelschuetze
emanuelschuetze requested changes Mar 14, 2024
View reviewed changes
Copy link
Member

@emanuelschuetze emanuelschuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@Elblinator Elblinator assigned reiterl and unassigned Elblinator Mar 15, 2024
@reiterl reiterl assigned reiterl and unassigned reiterl Mar 15, 2024
@reiterl reiterl requested a review from emanuelschuetze March 15, 2024 07:26
@reiterl reiterl assigned emanuelschuetze and Elblinator and unassigned reiterl Mar 15, 2024
@reiterl
Copy link
Member Author

reiterl commented Mar 15, 2024

I have added a midpoint option to the comma separated listing and use it here and moved the metadata above categories metadata.

@emanuelschuetze
Copy link
Member

One (string) remark. Midpoind and position is fine now.

@Elblinator Elblinator dismissed their stale review March 15, 2024 09:53

cr fullfilled and other remarks are already made

@Elblinator Elblinator removed their request for review March 15, 2024 09:54
@reiterl reiterl assigned emanuelschuetze and unassigned reiterl Mar 15, 2024
@rrenkert rrenkert merged commit 30d51cb into OpenSlides:main Mar 15, 2024
4 checks passed
@reiterl reiterl deleted the 3418-change-display-of-identical-text branch March 18, 2024 07:48
peb-adr added a commit to peb-adr/openslides-client that referenced this pull request Mar 20, 2024
@peb-adr
Merge staging/4.1.5 into stable/4.1.x. Update 20240320
62417a7 
* commit 'faf4189d28f0b7e6b528a545b5893866d9235acc': (52 commits)
  Update translations (OpenSlides#3451) (OpenSlides#3454)
  Prevent some linter warnings and make OS4 more accessiblle (OpenSlides#3103)
  Change display of identical motions (OpenSlides#3425)
  Hide statute amendments checkbox (OpenSlides#3440)
  Test MeetingSettingDirective (OpenSlides#3437)
  Test TreeSortService (OpenSlides#3443)
  Update mdc dialog (OpenSlides#3397)
  Update all translations (OpenSlides#3417)
  Prevent certain speech state changes (OpenSlides#3395)
  Change label color of focused form field in dark mode (OpenSlides#3399)
  Improve service worker update flow (OpenSlides#3368)
  Update meta (OpenSlides#3392)
  Change motion delete warnings (OpenSlides#3373)
  Fix delete speakers from view model list (OpenSlides#3375)
  Make own structure_level changeable (OpenSlides#3374)
  Fix moderation note permission updates (OpenSlides#3365)
  Add staging branch to CI
  Add arrow back to contributions list (OpenSlides#3364)
  add username sort option to account list (OpenSlides#3434)
  Activate re-add button only if active speaker is true (OpenSlides#3380)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsangmeister jsangmeister jsangmeister approved these changes

@bastianjoel bastianjoel bastianjoel approved these changes

@emanuelschuetze emanuelschuetze emanuelschuetze approved these changes

@Elblinator Elblinator Awaiting requested review from Elblinator

Assignees

@emanuelschuetze emanuelschuetze

Labels
enhancement General enhancement which is neither bug nor feature
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Change display of 'identical motions'-list
6 participants
@reiterl @jsangmeister @emanuelschuetze @bastianjoel @Elblinator @rrenkert