Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes amendment detail change recommendation #3266

Conversation

reiterl
Copy link
Member

@reiterl reiterl commented Feb 8, 2024

The motion detail with the line numbering is difficult.

This pull request should solve case A and B1 from #2946
But there are still some strange behaviour in there.

@reiterl reiterl added the bug label Feb 8, 2024
@reiterl reiterl added this to the 4.2 milestone Feb 8, 2024
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B1 is fixed

If the amendment has a change recommendation only the line with change recommendation is now displayed in the diff version:
001

@Elblinator Elblinator assigned reiterl and unassigned bastianjoel and Elblinator Feb 13, 2024
@reiterl
Copy link
Member Author

reiterl commented Feb 16, 2024

I can see that, but it is the amendment diff displayed. I just set diff mode. These components are cans of worms.

@reiterl reiterl removed their assignment Feb 21, 2024
@reiterl
Copy link
Member Author

reiterl commented Feb 21, 2024

I won't continue here.

@bastianjoel
Copy link
Member

Please update your PR to just fix part of the issue and maybe remove regressions, close it or provide further detail on how we should proceed with this.

@reiterl
Copy link
Member Author

reiterl commented Mar 5, 2024

As I won't continue here, I close this pr.

@reiterl reiterl closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants