Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create user from string with username generated in backend #3219

Merged

Conversation

reiterl
Copy link
Member

@reiterl reiterl commented Jan 29, 2024

Resolve #2921

In this pullrequest I have slightly changed the createFromString function, to allow the backend to generate the username.

@reiterl reiterl requested review from bastianjoel and MSoeb January 29, 2024 09:09
@reiterl reiterl changed the title Create user from string with username generate in backend Create user from string with username generated in backend Jan 29, 2024
@reiterl reiterl added this to the 4.2 milestone Jan 29, 2024
@Elblinator Elblinator self-requested a review February 2, 2024 09:42
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the User which is created should be inactive

currently the created account/participant is active, please change this to inactive

after a user is created a snackbar should open which says: "A user with the Surname 'bla bla' and the username 'blabla' was created"

this is currently missing, please add

@Elblinator Elblinator assigned reiterl and unassigned bastianjoel and MSoeb Feb 2, 2024
@reiterl reiterl requested a review from Elblinator February 5, 2024 10:35
@reiterl reiterl assigned Elblinator and bastianjoel and unassigned reiterl Feb 5, 2024
@reiterl
Copy link
Member Author

reiterl commented Feb 5, 2024

I have added code for set inactive and opening the snackbar.

@Elblinator Elblinator assigned reiterl and unassigned bastianjoel and Elblinator Feb 12, 2024
@reiterl reiterl requested a review from bastianjoel February 12, 2024 10:53
@reiterl reiterl assigned bastianjoel and Elblinator and unassigned reiterl Feb 12, 2024
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that the name is saved in first and last or only the first name:
Please change the snackbar message from the last name/ Surname to the first name

@Elblinator Elblinator assigned reiterl and unassigned bastianjoel and Elblinator Feb 13, 2024
@reiterl reiterl requested a review from Elblinator February 13, 2024 08:12
@reiterl
Copy link
Member Author

reiterl commented Feb 13, 2024

Changed the snackbar message to use first name instead of last name.

@reiterl reiterl assigned bastianjoel and Elblinator and unassigned reiterl Feb 13, 2024
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function

@reiterl reiterl requested a review from jsangmeister February 13, 2024 12:09
@bastianjoel bastianjoel removed their assignment Feb 13, 2024
@Elblinator Elblinator merged commit 3f57302 into OpenSlides:main Feb 13, 2024
3 checks passed
@reiterl reiterl deleted the 2921-create-user-with-generate-username branch February 13, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "+ create User" action in participant search fields
5 participants