Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent some linter warnings and make OS4 more accessiblle #3103

Merged
merged 26 commits into from
Mar 15, 2024
Merged

Prevent some linter warnings and make OS4 more accessiblle #3103

merged 26 commits into from
Mar 15, 2024

Conversation

Elblinator
Copy link
Member

@Elblinator Elblinator commented Dec 14, 2023 •
edited
Loading

closes part of #3079

Notes for testing:
which objects changed (are now reachable with tab and usable with enter)

  • meeting > setting-list
  • copyright sign (and more)
  • chat groups
  • in file-list visual for focused files is different
  • in file-liste folder are focusable
  • "Hide more text"/"Show full text" (e.g. see motions -> comment)

@Elblinator Elblinator self-assigned this Dec 14, 2023
@Elblinator Elblinator added this to the 4.2 milestone Dec 14, 2023
@Elblinator Elblinator marked this pull request as ready for review January 12, 2024 06:59
@Elblinator Elblinator assigned bastianjoel and unassigned Elblinator Jan 12, 2024
@Elblinator Elblinator requested a review from MSoeb January 12, 2024 10:45
@Elblinator Elblinator assigned rrenkert and unassigned MSoeb Jan 12, 2024
@Elblinator Elblinator requested review from rrenkert and removed request for MSoeb January 12, 2024 14:49
@Elblinator Elblinator changed the title Fix linter warnings Prevent some linter warnings and make OS4 more accessiblle Jan 12, 2024
@rrenkert rrenkert linked an issue Jan 15, 2024 that may be closed by this pull request
Fix linter warnings for accessibility #3079
Closed
@jsangmeister
Copy link
Contributor

ping @rrenkert @bastianjoel

@bastianjoel bastianjoel removed their assignment Feb 6, 2024
rrenkert
rrenkert requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@rrenkert rrenkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metting->Settings is available via enter the backspace navigation is missing but should be availbale.
File-list is lacking the navigation to edit dialog via row item 'groups'

@rrenkert rrenkert assigned Elblinator and unassigned rrenkert Feb 15, 2024
@Elblinator
Copy link
Member Author

Elblinator commented Mar 11, 2024 •
edited
Loading

Metting->Settings is available via enter the backspace navigation is missing but should be availbale.

You can navigate back with alt + arrow left and you do not need tab to navigate back

@Elblinator Elblinator requested a review from rrenkert March 11, 2024 10:21
@Elblinator Elblinator assigned rrenkert and unassigned Elblinator Mar 11, 2024
@Elblinator Elblinator enabled auto-merge (squash) March 15, 2024 13:58
@Elblinator Elblinator merged commit 666876a into OpenSlides:main Mar 15, 2024
2 checks passed
peb-adr added a commit to peb-adr/openslides-client that referenced this pull request Mar 20, 2024
@peb-adr
Merge staging/4.1.5 into stable/4.1.x. Update 20240320
62417a7 
* commit 'faf4189d28f0b7e6b528a545b5893866d9235acc': (52 commits)
  Update translations (OpenSlides#3451) (OpenSlides#3454)
  Prevent some linter warnings and make OS4 more accessiblle (OpenSlides#3103)
  Change display of identical motions (OpenSlides#3425)
  Hide statute amendments checkbox (OpenSlides#3440)
  Test MeetingSettingDirective (OpenSlides#3437)
  Test TreeSortService (OpenSlides#3443)
  Update mdc dialog (OpenSlides#3397)
  Update all translations (OpenSlides#3417)
  Prevent certain speech state changes (OpenSlides#3395)
  Change label color of focused form field in dark mode (OpenSlides#3399)
  Improve service worker update flow (OpenSlides#3368)
  Update meta (OpenSlides#3392)
  Change motion delete warnings (OpenSlides#3373)
  Fix delete speakers from view model list (OpenSlides#3375)
  Make own structure_level changeable (OpenSlides#3374)
  Fix moderation note permission updates (OpenSlides#3365)
  Add staging branch to CI
  Add arrow back to contributions list (OpenSlides#3364)
  add username sort option to account list (OpenSlides#3434)
  Activate re-add button only if active speaker is true (OpenSlides#3380)
  ...
@Elblinator Elblinator deleted the 3079-linter-accessibility branch April 24, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianjoel bastianjoel bastianjoel approved these changes

@rrenkert rrenkert rrenkert approved these changes

Assignees

@rrenkert rrenkert

Labels
accessibility
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Fix linter warnings for accessibility
5 participants
@Elblinator @jsangmeister @bastianjoel @rrenkert @MSoeb