-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix analog default election mode #3009
Merged
m-schieder
merged 3 commits into
OpenSlides:main
from
bastianjoel:3008-fix-default-election-mode-analog
Nov 13, 2023
Merged
Fix analog default election mode #3009
m-schieder
merged 3 commits into
OpenSlides:main
from
bastianjoel:3008-fix-default-election-mode-analog
Nov 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisa-beerboom
requested changes
Nov 13, 2023
@@ -75,7 +75,7 @@ export class TopicPollService extends PollService { | |||
const poll: Partial<Poll> = { | |||
title: this.translate.instant(`Vote`), | |||
onehundred_percent_base: this.defaultPercentBase, | |||
entitled_group_ids: Object.values(this.defaultGroupIds), | |||
entitled_group_ids: Object.values(this.defaultGroupIds ?? {}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use an array
luisa-beerboom
approved these changes
Nov 13, 2023
MSoeb
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Found no issues.
m-schieder
added a commit
that referenced
this pull request
Nov 13, 2023
* commit 'bf78a207a4b47dc0cefef536e403aed436654633': Fix analog default election mode (#3009) Add sorting to workflow next states (comma-list, menu) (#2983) Account import improvements (#2919) Motion block update place of recommender (#2989) Update material tabs and slider to mdc (#2998) change string (#2993)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3008
Also includes a fix that caused css vars not being available in darkmode.