Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analog default election mode #3009

Merged

Conversation

bastianjoel
Copy link
Member

resolves #3008

Also includes a fix that caused css vars not being available in darkmode.

@bastianjoel bastianjoel added bug critical Highest priority: This has to be done first. labels Nov 13, 2023
@bastianjoel bastianjoel added this to the 4.1 milestone Nov 13, 2023
@@ -75,7 +75,7 @@ export class TopicPollService extends PollService {
const poll: Partial<Poll> = {
title: this.translate.instant(`Vote`),
onehundred_percent_base: this.defaultPercentBase,
entitled_group_ids: Object.values(this.defaultGroupIds),
entitled_group_ids: Object.values(this.defaultGroupIds ?? {}),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use an array

@luisa-beerboom luisa-beerboom removed their assignment Nov 13, 2023
@MSoeb MSoeb self-requested a review November 13, 2023 13:23
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Found no issues.

@MSoeb MSoeb removed the request for review from rrenkert November 13, 2023 13:24
@m-schieder m-schieder merged commit bf78a20 into OpenSlides:main Nov 13, 2023
4 checks passed
@bastianjoel bastianjoel deleted the 3008-fix-default-election-mode-analog branch November 13, 2023 13:32
m-schieder added a commit that referenced this pull request Nov 13, 2023
* commit 'bf78a207a4b47dc0cefef536e403aed436654633':
  Fix analog default election mode (#3009)
  Add sorting to workflow next states (comma-list, menu) (#2983)
  Account import improvements (#2919)
  Motion block update place of recommender (#2989)
  Update material tabs and slider to mdc (#2998)
  change string (#2993)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug critical Highest priority: This has to be done first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polls/elections: problem with default value analog
5 participants