Add sorting to workflow next states (comma-list, menu) #2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastianjoel
approved these changes
Nov 10, 2023
| @@ -106,7 +106,7 @@ <h2 *ngIf="workflow"> | |||
| <div class="inner-table"> | |||
| <div *ngIf="!state.next_states.length">-</div> | |||
| <div *ngIf="state.next_states.length"> | |||
| <os-comma-separated-listing [list]="state.next_states"> | |||
| <os-comma-separated-listing [list]="sortedNextStates(state)"> | |||
There was a problem hiding this comment.
This can cause performance issues because this gets calculated on every change detection cycle and the underlying method performs a sort.
However, because the next states might be quite small in most cases I approve.
m-schieder
added a commit
that referenced
this pull request
Nov 13, 2023
* commit 'bf78a207a4b47dc0cefef536e403aed436654633': Fix analog default election mode (#3009) Add sorting to workflow next states (comma-list, menu) (#2983) Account import improvements (#2919) Motion block update place of recommender (#2989) Update material tabs and slider to mdc (#2998) change string (#2993)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2929