Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update global search to show marks bolder #2879

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

reiterl
Copy link
Member

@reiterl reiterl commented Oct 11, 2023

Resolves "the searched word is not bold (good first issue)" of #2738

Global search result title are no longer marked.
mark tags are now bolder.

Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the titles are still not bold (Agenda, Motion, Election, File

@Elblinator Elblinator assigned reiterl and unassigned bastianjoel and Elblinator Oct 12, 2023
@bastianjoel
Copy link
Member

bastianjoel commented Oct 12, 2023

The marks should not be visible in titles as far as I understood.

@bastianjoel bastianjoel assigned Elblinator and unassigned reiterl Oct 12, 2023
@Elblinator
Copy link
Member

After reconsidering the desired Thanks for pointing that out
I'll update the change request accordingly

@Elblinator Elblinator dismissed their stale review October 12, 2023 10:06

missunderstanding in desired change

Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If an account is found, then the part of the account which matched with the searched word is bold.
The titles of the results should not be bold

@Elblinator Elblinator assigned reiterl and unassigned Elblinator Oct 12, 2023
@reiterl reiterl requested a review from Elblinator October 13, 2023 08:27
@reiterl reiterl assigned Elblinator and bastianjoel and unassigned reiterl Oct 13, 2023
@reiterl
Copy link
Member Author

reiterl commented Oct 13, 2023

Add code to prevent marking in account case.

Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function

@Elblinator Elblinator enabled auto-merge (squash) October 20, 2023 13:55
@Elblinator Elblinator merged commit ba710fb into OpenSlides:main Oct 20, 2023
2 checks passed
@reiterl reiterl deleted the global-search-mark-bold branch October 23, 2023 07:16
m-schieder added a commit that referenced this pull request Nov 1, 2023
* commit 'de1c41c440e2769f30db848afed513db289c3dba':
  Add missing field to history subscription (#2915)
  Update projection-edit-dialog to fix bugs (#2891)
  Fix meeting history using wrong user repo (#2889)
  Fix conflicting amendment projection (#2887)
  Add perm check to remove from motion block (#2883)
  Change shown sequential number and add a space (#2881)
  Update global search to show marks bolder (#2879)
  Prevent add ballot if deleted users (#2873)
  Fix autoupdate request flooding after logout (#2907)
  Bump tinymce from 5.10.7 to 5.10.8 in /client (#2920)
  Add tests for the color service (#2928)
  Bump @babel/traverse from 7.21.3 to 7.23.2 in /client (#2910)
  Update angular (#2810)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants