-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update motion workflow export #2862
Update motion workflow export #2862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allow_motion_forwarding and set_workflow_timestamp are only exported if it was activated once
It should always be exported even if it was never true
The reason why this happens is because all other workflow fields have defaults set in the backend. This causes the value to be automatically set in the backend upon workflow creation, meaning that those fields will have a value, even if they were never changed. Therefore even the fields that are off by default technically have a value at the start, except for the two new fields which have no default set and will therefore initialized without a value (which will be interpreted as "false" in the client). There are multiple ways in which this may be changed.
Given that the workflow.import and all workflow-related functionality will still work perfectly fine with how the system currently is, however, I question whether it is really necessary to change anything here. What do you think would be best @Elblinator @rrenkert |
Please implement option 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the new course of action the client PR is working fine. Before merging however the back-end should be adjusted
Do we really want to add a migration for this? It feels like a huge overhead when the client could just fill in empty boolean fields with |
* commit 'e7432ec2412d0377a158ecee44f5964a31c767a3': Make router service consider ongoing navigation before login navigation (#3069) Remove translation marker (#3061) Display password change errors (#3056) Align Multiselect Text centered (#2976) Add tooltips (#2407) Fix reload cancel causing issues (#3053) Fix linenumber skip resulting in error in textNodeToLines (#3050) Update motion workflow export (#2862) Fix os-list filter bar slot (#3049) Fix linter warnings (#3035) Remove unused css classes (#3043)
Close #2555