Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clear selection option in search-selector #2860

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Add clear selection option in search-selector #2860

merged 4 commits into from
Oct 9, 2023

Conversation

reiterl
Copy link
Member

@reiterl reiterl commented Oct 6, 2023

Closes #2850

@reiterl reiterl added the enhancement General enhancement which is neither bug nor feature label Oct 6, 2023
@reiterl reiterl added this to the 4.1 milestone Oct 6, 2023
bastianjoel
bastianjoel requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@bastianjoel bastianjoel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to make this optional by creating a new input property for the search selector component.

@bastianjoel bastianjoel assigned reiterl and unassigned bastianjoel and rrenkert Oct 6, 2023
@reiterl reiterl requested a review from bastianjoel October 9, 2023 07:21
@reiterl reiterl assigned bastianjoel and rrenkert and unassigned reiterl Oct 9, 2023
@bastianjoel bastianjoel assigned Elblinator and unassigned bastianjoel and rrenkert Oct 9, 2023
@bastianjoel bastianjoel requested review from Elblinator and removed request for rrenkert October 9, 2023 08:02
@Elblinator Elblinator added bug and removed enhancement General enhancement which is neither bug nor feature labels Oct 9, 2023
Elblinator
Elblinator requested changes Oct 9, 2023
View reviewed changes
.../modules/search-selector/components/base-search-selector/base-search-selector.component.html Outdated
@@ -68,6 +68,7 @@
>
{{ noOptionsFoundLabel | translate }}
</mat-option>
<mat-option *ngIf="addClearSelection" translate>Clear selection</mat-option>
Copy link
Member

@Elblinator Elblinator Oct 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency-sake I would suggest a single minus

Suggested change
<mat-option *ngIf="addClearSelection" translate>Clear selection</mat-option>
<mat-option *ngIf="addClearSelection">-</mat-option>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Elblinator Elblinator assigned reiterl and unassigned Elblinator Oct 9, 2023
@reiterl reiterl requested a review from Elblinator October 9, 2023 10:21
@reiterl reiterl removed their assignment Oct 9, 2023
@reiterl reiterl force-pushed the clear-selection-button branch from 9e1b6d2 to 11d35fb Compare October 9, 2023 10:41
@Elblinator Elblinator merged commit ab0c23b into OpenSlides:main Oct 9, 2023
2 checks passed
@reiterl reiterl deleted the clear-selection-button branch October 9, 2023 13:03
peb-adr added a commit that referenced this pull request Oct 18, 2023
@peb-adr
Merge main into stable/4.0.x. Update 20231018
062db2c 
* commit 'aa450618f8647a5c7595771cb101eb01f94b6e71': (46 commits)
  Fix route state undefined (#2905)
  Revert "Fix search selection option focus (#2842)" (#2902)
  Fix meeting admin update as committee admin (#2901)
  Fix move in call list functionality (#2861)
  Add ability to go back to lead motion after amendment create (#2859)
  Block motions/tags page, if missing permission (#2857)
  Add info message to list of speakers content, if present is needed (#2854)
  Fix monospace font wrong weight on include (#2848)
  Fix participant history error (#2888)
  Add tests for list-search.service (#2874)
  Fix remove and add submitters (#2858)
  Add clear selection option in search-selector (#2860)
  Pause autoupdate connection on inactivitiy (#2851)
  Fix linting (#2867)
  Improve shared worker restart after reload process (#2847)
  Fix search service issues (#2844)
  Fix bulk change Submitters (#2846)
  Add test for CsvExportForBackendService (#2863)
  Fix double click needed to remove filter (#2856)
  Add lines between class members eslint rule (#2849)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elblinator Elblinator Elblinator approved these changes

@bastianjoel bastianjoel bastianjoel approved these changes

Assignees

@Elblinator Elblinator

Labels
bug
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Motion create deselect category
4 participants
@reiterl @bastianjoel @Elblinator @rrenkert