Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double click needed to remove filter #2856

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

bastianjoel
Copy link
Member

resolves #2357

I consider this a workaround. It seems when blurring focus of a checkbox from the filters a mousedown event is fired which prevents the click event on the filter from getting fired. I could not figure out why this happens. Especially why only on the participant list.

@bastianjoel bastianjoel force-pushed the 2357-fix-filter-deselect branch from 1fb2db6 to 49a1c04 Compare October 5, 2023 09:35
@bastianjoel
Copy link
Member Author

An additional observation was that the Delegation of vote filters were not removable at all via the X whereas the other filters just needed 2-3 clicks.

@luisa-beerboom luisa-beerboom removed their assignment Oct 6, 2023
@Elblinator Elblinator self-assigned this Oct 9, 2023
@Elblinator Elblinator self-requested a review October 9, 2023 07:21
@Elblinator Elblinator removed the request for review from rrenkert October 9, 2023 07:21
@Elblinator Elblinator merged commit 80e0202 into OpenSlides:main Oct 9, 2023
3 checks passed
@bastianjoel bastianjoel deleted the 2357-fix-filter-deselect branch October 9, 2023 07:40
peb-adr added a commit that referenced this pull request Oct 18, 2023
* commit 'aa450618f8647a5c7595771cb101eb01f94b6e71': (46 commits)
  Fix route state undefined (#2905)
  Revert "Fix search selection option focus (#2842)" (#2902)
  Fix meeting admin update as committee admin (#2901)
  Fix move in call list functionality (#2861)
  Add ability to go back to lead motion after amendment create (#2859)
  Block motions/tags page, if missing permission (#2857)
  Add info message to list of speakers content, if present is needed (#2854)
  Fix monospace font wrong weight on include (#2848)
  Fix participant history error (#2888)
  Add tests for list-search.service (#2874)
  Fix remove and add submitters (#2858)
  Add clear selection option in search-selector (#2860)
  Pause autoupdate connection on inactivitiy (#2851)
  Fix linting (#2867)
  Improve shared worker restart after reload process (#2847)
  Fix search service issues (#2844)
  Fix bulk change Submitters (#2846)
  Add test for CsvExportForBackendService (#2863)
  Fix double click needed to remove filter (#2856)
  Add lines between class members eslint rule (#2849)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't remove current filters via buttons in filter-bar sometimes
4 participants