Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix motion-with-amendment dialog #2818

Closed
wants to merge 3 commits into from
Closed

Fix motion-with-amendment dialog #2818

wants to merge 3 commits into from

Conversation

Elblinator
Copy link
Member

@Elblinator Elblinator commented Sep 18, 2023 •
edited
Loading

unlink pr and Issue #2676

@Elblinator Elblinator added the enhancement General enhancement which is neither bug nor feature label Sep 18, 2023
@Elblinator Elblinator marked this pull request as ready for review September 18, 2023 11:09
@Elblinator Elblinator requested a review from MSoeb September 18, 2023 11:23
@Elblinator Elblinator assigned MSoeb and unassigned bastianjoel Sep 18, 2023
emanuelschuetze
emanuelschuetze requested changes Sep 29, 2023
View reviewed changes
Copy link
Member

@emanuelschuetze emanuelschuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a better list of amendments - in a separate paragraph and short the list by using number of amendments (instead of number AND title). See screenshot.

See example with current PR:
amendment-dialog1

Desired formatting:
amendments-dialog2

@emanuelschuetze emanuelschuetze assigned Elblinator and unassigned MSoeb Sep 29, 2023
@Elblinator Elblinator removed the request for review from MSoeb October 23, 2023 14:59
@bastianjoel bastianjoel deleted the 2676-motion-with-amendment-dialog branch October 24, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emanuelschuetze emanuelschuetze emanuelschuetze requested changes

@bastianjoel bastianjoel bastianjoel approved these changes

Assignees

@Elblinator Elblinator

Labels
enhancement General enhancement which is neither bug nor feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Elblinator @emanuelschuetze @bastianjoel @MSoeb