Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix participant-create-wizard #2815

Merged

Conversation

luisa-beerboom
Copy link
Member

@luisa-beerboom luisa-beerboom commented Sep 18, 2023

While trying to replicate #2787 (which I didn't manage to do at first) I instead found that the meeting-specific information form didn't appear for a meeting admin trying to add a user from another meeting.

I fixed that one.

Also fixes #2787

Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The meeting specific information is still missing.
Additional information:
the meeting specific information is only missing in the dev-environment
I could not reconstruct this behaviour in production-environment

to trigger #2787 you need an autoupdate.
e.g. be at the broken mask and then set yourself present or not present

@luisa-beerboom
Copy link
Member Author

The meeting specific information is still missing. Additional information: the meeting specific information is only missing in the dev-environment I could not reconstruct this behaviour in production-environment

It is fixed for me in firefox and chromium, what exactly are you doing?

to trigger #2787 you need an autoupdate. e.g. be at the broken mask and then set yourself present or not present

Doesn't work for me. The personal information form flickers a bit, but there's no permanent enabling. Does this only happen in prod or smth?

@Elblinator
Copy link
Member

Elblinator commented Sep 19, 2023

The meeting specific information is still missing. Additional information: the meeting specific information is only missing in the dev-environment I could not reconstruct this behaviour in production-environment

It is fixed for me in firefox and chromium, what exactly are you doing?

to trigger #2787 you need an autoupdate. e.g. be at the broken mask and then set yourself present or not present

Doesn't work for me. The personal information form flickers a bit, but there's no permanent enabling. Does this only happen in prod or smth?

preparation:

  1. make services-to-main
  2. checkout fix-participant-create-wizard
  3. make run-dev
  4. autoupdateOnSharedWorker: false

in localhost:

  1. create participant X in meeting A
  2. login as (admin) Y, Y is an admin in meeting B,
  3. put yourself on present
  4. start creating a new participant, select participant X in step 2
  5. put yourself from present to not present to present
  6. the following is my view:
    personal_page

error-message in the console:
(sarah has the id 40)
error

@luisa-beerboom
Copy link
Member Author

Can't replicate this, unless X is also in another meeting. Please mention such things.

@bastianjoel bastianjoel removed their assignment Sep 26, 2023
@bastianjoel bastianjoel assigned rrenkert and unassigned Elblinator Sep 26, 2023
@bastianjoel bastianjoel requested review from Elblinator and removed request for Elblinator September 26, 2023 07:55
Copy link
Member

@rrenkert rrenkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The form is no more editable but on every change of the present status the form fields flicker from disabled to enabled and back to disabled.

@rrenkert rrenkert assigned luisa-beerboom and unassigned rrenkert Sep 26, 2023
@luisa-beerboom
Copy link
Member Author

The form is no more editable but on every change of the present status the form fields flicker from disabled to enabled and back to disabled.

That is a pre-existing bug. It should not be considered as part of this PR. Please create a separate issue.

@rrenkert rrenkert merged commit 0fd4488 into OpenSlides:main Sep 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent possibility to edit "new participant"
4 participants