Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Livestream window should not overlap other elements #2411

Merged

Conversation

luisa-beerboom
Copy link
Member

@luisa-beerboom luisa-beerboom commented Jun 13, 2023

Closes #2367

Also restyles some views that didn't use standard OpenSlides card styling (category-detail, category-list-sort), please have a look at category detail in particular when testing

@luisa-beerboom luisa-beerboom added this to the 4.1 milestone Jun 13, 2023
@luisa-beerboom luisa-beerboom marked this pull request as ready for review June 15, 2023 14:41
Copy link
Member

@emanuelschuetze emanuelschuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please add a border bottom line for the last table line
  • Add more bottom space in settings view (e.g. motion settings)

Copy link
Member

@bastianjoel bastianjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer adding the spacing globally to a container element.

@luisa-beerboom
Copy link
Member Author

I would prefer adding the spacing globally to a container element.

I tried that it did the following to the list views:

Screenshot_20230621_115514

I don't think that is desirable

@luisa-beerboom
Copy link
Member Author

luisa-beerboom commented Jun 21, 2023

@emanuelschuetze

  1. I took out the bottom lines for the list views specifically because it would make the new spacer look like there is some artefact data that isn't being displayed properly. Do you have an idea how I may avoid that situation while keeping the bottom-line, if so I can do that.
  2. Why should the meeting settings get even more spacer? They already have the standard 60px spacer that is necessary to accommodate the livestream window?

Copy link
Member

@rrenkert rrenkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we detect the state of livestream, applause icon and virtual helpdesk icon? The empty space if none of them are visible looks broken.
A bottom border on the last element does not look like a broken item if the icons/livestream window are present.

@Elblinator
Copy link
Member

like raimund said, the bottom border and the additional space should only be present if the livestream window is activated, but they should be both present for-list views.

this is how a singular setting-page looks like if the livestream is present:
Screenshot_20230828_135839

every mat-card should end and then have a margin to the end of the page (independent of the live stream)
Example:
Screenshot_20230828_141308

@luisa-beerboom luisa-beerboom force-pushed the 2367-livestream-window-overlaps-other-ui branch from 5ab925c to 3093aef Compare September 4, 2023 09:20
@@ -171,7 +171,7 @@ <h2>{{ projector.name }}</h2>
<hr />
</div>

<div>
<div class="spacer-bottom-60">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be the wrong container for the spacer. This one creates a second scrollbar on smaller screens.
Tested in brave (chromium based).

@luisa-beerboom
Copy link
Member Author

luisa-beerboom commented Sep 15, 2023

Had to revert the meeting part of #2230, I think I fixed it again but please check if there are weird scrolling bugs anywhere in the meeting
@Elblinator @rrenkert

@rrenkert rrenkert dismissed emanuelschuetze’s stale review September 19, 2023 12:19

The requested changes are implemented.

@Elblinator Elblinator removed their assignment Sep 19, 2023
@rrenkert rrenkert merged commit e237b39 into OpenSlides:main Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: livestream window overlaps other ui elements
5 participants