-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Livestream window should not overlap other elements #2411
Livestream window should not overlap other elements #2411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please add a border bottom line for the last table line
- Add more bottom space in settings view (e.g. motion settings)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer adding the spacing globally to a container element.
|
a4025fd
to
5ab925c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we detect the state of livestream, applause icon and virtual helpdesk icon? The empty space if none of them are visible looks broken.
A bottom border on the last element does not look like a broken item if the icons/livestream window are present.
5ab925c
to
3093aef
Compare
e857b71
to
30cc138
Compare
@@ -171,7 +171,7 @@ <h2>{{ projector.name }}</h2> | |||
<hr /> | |||
</div> | |||
|
|||
<div> | |||
<div class="spacer-bottom-60"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be the wrong container for the spacer. This one creates a second scrollbar on smaller screens.
Tested in brave (chromium based).
Had to revert the meeting part of #2230, I think I fixed it again but please check if there are weird scrolling bugs anywhere in the meeting |
The requested changes are implemented.
Closes #2367
Also restyles some views that didn't use standard OpenSlides card styling (category-detail, category-list-sort), please have a look at category detail in particular when testing