Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign election ballots #2214

Merged
merged 23 commits into from
Jun 25, 2024
Merged

Redesign election ballots #2214

merged 23 commits into from
Jun 25, 2024

Conversation

luisa-beerboom
Copy link
Member

@luisa-beerboom luisa-beerboom commented Apr 19, 2023 •
edited
Loading

Closes #2128

  • Zebra layout for list (i.e. grey background for every other line)
  • strike text in red
  • Vote area should probably vanish along with the "send vote" button if vote has been sent

@luisa-beerboom luisa-beerboom added this to the 4.1 milestone Apr 19, 2023
@luisa-beerboom luisa-beerboom self-assigned this Apr 19, 2023
@rrenkert rrenkert modified the milestones: 4.1, 4.x Dec 8, 2023
@Elblinator
Copy link
Member

This should be reevaluated and then a new PR should be created

@Elblinator Elblinator closed this Feb 1, 2024
@luisa-beerboom luisa-beerboom reopened this Mar 5, 2024
@luisa-beerboom
Copy link
Member Author

I actually managed to update this, so - reopened!

Still needs work though

@luisa-beerboom luisa-beerboom marked this pull request as ready for review March 6, 2024 14:23
@luisa-beerboom
Copy link
Member Author

There may be some bugs still, after all, this has been merge-updated from a very old PR

@Elblinator Elblinator modified the milestones: 4.x, 4.2 Mar 7, 2024
@emanuelschuetze
Copy link
Member

as discussed last week

emanuelschuetze
emanuelschuetze requested changes May 24, 2024
View reviewed changes
Copy link
Member

@emanuelschuetze emanuelschuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed:

  • structure level is missing in ballot
  • mobile theme for ballot required

@emanuelschuetze emanuelschuetze removed their assignment Jun 25, 2024
@bastianjoel bastianjoel merged commit 0a160f2 into OpenSlides:main Jun 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianjoel bastianjoel bastianjoel approved these changes

@emanuelschuetze emanuelschuetze emanuelschuetze approved these changes

Assignees

@bastianjoel bastianjoel

Labels
feature Strutt projectname ui
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Redesign election ballot
6 participants
@luisa-beerboom @Elblinator @Eich-hoernchen @emanuelschuetze @bastianjoel @rrenkert