Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection to ICC service gets closed after 30min #3248

Closed
jsangmeister opened this issue Feb 2, 2024 · 3 comments · Fixed by #3276
Closed

Connection to ICC service gets closed after 30min #3248

jsangmeister opened this issue Feb 2, 2024 · 3 comments · Fixed by #3276
Assignees
@bastianjoel
Labels
enhancement General enhancement which is neither bug nor feature high
Milestone
4.2

Comments

@jsangmeister
Copy link
Contributor

jsangmeister commented Feb 2, 2024 •
edited
Loading

This is a very critical issue as this prevents meetings from functioning correctly and browsers are used by about 100% of all users (https://en.wikipedia.org/wiki/Usage_share_of_web_browsers). As this does not happen for the autoupdate connection which is handled by the shared worker, we suspect that moving the ICC connection to the shared worker might sove this issue. Therefore, we should move the ICC handling to the shared worker ASAP.
@jsangmeister jsangmeister added bug blocker critical Highest priority: This has to be done first. labels Feb 2, 2024
@jsangmeister jsangmeister added this to the 4.2 milestone Feb 2, 2024
@jsangmeister jsangmeister changed the title Connection to ICC service in Chrome gets closed after 30min Connection to ICC service gets closed after 30min Feb 2, 2024
@jsangmeister
Copy link
Contributor Author

Nevermind, it was a timeout in our code.

@jsangmeister
Copy link
Contributor Author

The timeout is set in

openslides-client/client/src/app/site/services/communication-manager.service/stream-handler.ts

Line 41 in 5ceb330

this._refreshTimer = setInterval(() => this.reboot(), 1000 * 60 * 30); // 30 min

@jsangmeister
Copy link
Contributor Author

@bastianjoel wants to move the ICC to the shared worker anyway.

@jsangmeister jsangmeister reopened this Feb 2, 2024
@jsangmeister jsangmeister added enhancement General enhancement which is neither bug nor feature critical Highest priority: This has to be done first. and removed bug blocker high critical Highest priority: This has to be done first. labels Feb 2, 2024
This was referenced Feb 3, 2024
Closed
Closed
@bastianjoel bastianjoel added high and removed critical Highest priority: This has to be done first. labels Feb 6, 2024
@Elblinator Elblinator linked a pull request Feb 13, 2024 that will close this issue
Move ICC to shared worker #3252
Closed
@bastianjoel bastianjoel mentioned this issue Feb 13, 2024
Merged
9 tasks
@luisa-beerboom luisa-beerboom mentioned this issue Feb 16, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bastianjoel bastianjoel

Labels
enhancement General enhancement which is neither bug nor feature high
Projects
None yet
Milestone
4.2
2 participants
@bastianjoel @jsangmeister