Set default for errorName in isNumberRange validator

OpenSlides · Dec 19, 2024 · 32d6636 · 32d6636
1 parent 0c0f861
commit 32d6636
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/client/src/app/infrastructure/utils/validators/is-number-range.ts b/client/src/app/infrastructure/utils/validators/is-number-range.ts
@@ -1,6 +1,6 @@
 import { AbstractControl, ValidatorFn } from '@angular/forms';
 
-export function isNumberRange(minCtrlName: string, maxCtrlName: string, errorName: string): ValidatorFn {
+export function isNumberRange(minCtrlName: string, maxCtrlName: string, errorName: string = `rangeError`): ValidatorFn {
     return (formControl: AbstractControl): { [key: string]: any } | null => {
         const min = formControl.get(minCtrlName)!.value;
         const max = formControl.get(maxCtrlName)!.value;

diff --git a/client/src/app/infrastructure/utils/validators/validators.spec.ts b/client/src/app/infrastructure/utils/validators/validators.spec.ts
@@ -5,7 +5,7 @@ import { isUniqueAmong } from './is-unique-among';
 
 describe(`utils: validators`, () => {
     describe(`isNumberRange function`, () => {
-        const validatorFn = isNumberRange(`min`, `max`, `errorName`);
+        const validatorFn = isNumberRange(`min`, `max`);
         it(`test with correct values`, () => {
             const group = new UntypedFormGroup(
                 {

diff --git a/...pp/site/pages/meetings/modules/poll/components/base-poll-form/base-poll-form.component.ts b/...pp/site/pages/meetings/modules/poll/components/base-poll-form/base-poll-form.component.ts
@@ -473,7 +473,7 @@ export abstract class BasePollFormComponent extends BaseComponent implements OnI
             },
             {
                 validators: [
-                    isNumberRange(`min_votes_amount`, `max_votes_amount`, `rangeError`),
+                    isNumberRange(`min_votes_amount`, `max_votes_amount`),
                     this.enoughPollOptionsAvailable(`min_votes_amount`, `max_votes_per_option`),
                     isNumberRange(`max_votes_per_option`, `max_votes_amount`, `rangeErrorMaxPerOption`)
                 ]